Script 'mail_helper' called by ro Hello packager, This is just FYI. Your package was checked in in distribution "sle12" by autobuild-member: ro. Here comes the log... ---------------------------%<------------------------------ Hi, here is the log from ci_new_pac /mounts/work_src_done/SLE12/yast2 -> sle12 ## BNC# 876144 : "yast iscsi-lio-server reports Service Start set to 'Manually' even when starting on boot" (RESOLVED/FIXED) Changes: -------- --- /work/SRC/SUSE:SLE-12:GA/yast2/yast2.changes 2014-05-05 12:30:29.000000000 +0200 +++ /mounts/work_src_done/SLE12/yast2/yast2.changes 2014-05-05 14:13:18.000000000 +0200 @@ -1,0 +2,6 @@ +Mon May 5 11:38:34 UTC 2014 - vmoravec@suse.com + +- Fix getting the status of sysvinit services (bnc#876144) +- 3.1.60 + +------------------------------------------------------------------- calling whatdependson for sle12-i586 Packages directly triggered for rebuild: - yast2 - at least 73 other packages ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/SUSE:SLE-12:GA/yast2 (Old) and /mounts/work_src_done/SLE12/yast2 (BS:build ID:37371 MAIL:yast-commit@opensuse.org) (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Package is "yast2", Maintainer is "yast-commit@opensuse.org" Old: ---- yast2-3.1.59.tar.bz2 New: ---- yast2-3.1.60.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ yast2.spec ++++++ --- /var/tmp/diff_new_pack.wSonVg/_old 2014-05-05 17:42:17.000000000 +0200 +++ /var/tmp/diff_new_pack.wSonVg/_new 2014-05-05 17:42:17.000000000 +0200 @@ -17,7 +17,7 @@ Name: yast2 -Version: 3.1.59 +Version: 3.1.60 Release: 0 URL: https://github.com/yast/yast-yast2 ++++++ yast2-3.1.59.tar.bz2 -> yast2-3.1.60.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-3.1.59/library/systemd/src/lib/yast2/systemd_unit.rb new/yast2-3.1.60/library/systemd/src/lib/yast2/systemd_unit.rb --- old/yast2-3.1.59/library/systemd/src/lib/yast2/systemd_unit.rb 2014-05-02 16:35:44.000000000 +0200 +++ new/yast2-3.1.60/library/systemd/src/lib/yast2/systemd_unit.rb 2014-05-05 14:05:08.000000000 +0200 @@ -155,16 +155,41 @@ end extract_properties - self[:active?] = active_state == "active" - self[:running?] = sub_state == "running" - self[:loaded?] = load_state == "loaded" - self[:not_found?] = load_state == "not-found" - self[:enabled?] = unit_file_state == "enabled" + self[:active?] = active_state == "active" + self[:running?] = sub_state == "running" + self[:loaded?] = load_state == "loaded" + self[:not_found?] = load_state == "not-found" + self[:enabled?] = is_enabled? self[:supported?] = SUPPORTED_STATES.member?(unit_file_state) end private + # Check the value of #unit_file_state; its value mirrors UnitFileState dbus property + # @return [Boolean] True if enabled, False if not + def is_enabled? + # If UnitFileState property is missing due to e.g. legacy sysvinit service + # we must use a different way how to get the real status of the service + if unit_file_state.nil? + # Check for exit code of `systemctl is-enabled systemd_unit.name` ; additionally + # test the stdout of the command for valid values when the service is enabled + # http://www.freedesktop.org/software/systemd/man/systemctl.html#is-enabled%20...... + status = systemd_unit.command("is-enabled") + status.exit.zero? && state_name_enabled?(status.stdout) + else + state_name_enabled?(unit_file_state) + end + end + + # Systemd service unit can have various states like enabled, enabled-runtime, + # linked, linked-runtime, masked, masked-runtime, static, disabled, invalid. + # We test for the return value 'enabled' and 'enabled-runtime' to consider + # a service as enabled. + # @return [Boolean] True if enabled, False if not + def state_name_enabled? state + ["enabled", "enabled-runtime"].member?(state.strip) + end + def extract_properties systemd_unit.input_properties.each do |name, property| self[name] = raw[/#{property}=(.+)/, 1] @@ -215,11 +240,12 @@ end # Analyze the exit code and stdout of the command `systemctl is-enabled service_name` + # http://www.freedesktop.org/software/systemd/man/systemctl.html#is-enabled%20...... def service_missing? # the service exists and it's enabled return false if status.exit.zero? # the service exists and it's disabled - return false if status.exit.nonzero? && status.stdout.strip.match(/\Adisabled$/) + return false if status.exit.nonzero? && status.stdout.match(/disabled|masked|linked/) # for all other cases the service does not exist true end diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-3.1.59/package/yast2.changes new/yast2-3.1.60/package/yast2.changes --- old/yast2-3.1.59/package/yast2.changes 2014-05-02 16:35:44.000000000 +0200 +++ new/yast2-3.1.60/package/yast2.changes 2014-05-05 14:05:08.000000000 +0200 @@ -1,4 +1,10 @@ ------------------------------------------------------------------- +Mon May 5 11:38:34 UTC 2014 - vmoravec@suse.com + +- Fix getting the status of sysvinit services (bnc#876144) +- 3.1.60 + +------------------------------------------------------------------- Fri May 2 14:22:48 UTC 2014 - jreidinger@suse.com - save_y2logs: store target of symlinks as symlinks are useless diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-3.1.59/package/yast2.spec new/yast2-3.1.60/package/yast2.spec --- old/yast2-3.1.59/package/yast2.spec 2014-05-02 16:35:44.000000000 +0200 +++ new/yast2-3.1.60/package/yast2.spec 2014-05-05 14:05:08.000000000 +0200 @@ -17,7 +17,7 @@ Name: yast2 -Version: 3.1.59 +Version: 3.1.60 Release: 0 URL: https://github.com/yast/yast-yast2 continue with "q"... Checked in at Mon May 5 17:42:30 CEST 2014 by ro Remember to have fun... -- To unsubscribe, e-mail: yast-commit+unsubscribe@opensuse.org For additional commands, e-mail: yast-commit+help@opensuse.org