Author: fehr Date: Wed Mar 21 11:58:49 2012 New Revision: 67675 URL: http://svn.opensuse.org/viewcvs/yast?rev=67675&view=rev Log: change potential race of chmod after file create (bnc#753129) Modified: trunk/iscsi-client/package/yast2-iscsi-client.changes trunk/iscsi-client/src/IscsiClientLib.ycp Modified: trunk/iscsi-client/package/yast2-iscsi-client.changes URL: http://svn.opensuse.org/viewcvs/yast/trunk/iscsi-client/package/yast2-iscsi-client.changes?rev=67675&r1=67674&r2=67675&view=diff ============================================================================== --- trunk/iscsi-client/package/yast2-iscsi-client.changes (original) +++ trunk/iscsi-client/package/yast2-iscsi-client.changes Wed Mar 21 11:58:49 2012 @@ -4,6 +4,11 @@ - version 2.22.0 ------------------------------------------------------------------- +Wed Mar 21 11:48:21 CET 2012 - fehr@suse.de + +- change potential race of chmod after file create (bnc#753129) + +------------------------------------------------------------------- Mon Feb 6 14:05:22 CET 2012 - fehr@suse.de - change detection of qla iscsi devices (bnc#745201) Modified: trunk/iscsi-client/src/IscsiClientLib.ycp URL: http://svn.opensuse.org/viewcvs/yast/trunk/iscsi-client/src/IscsiClientLib.ycp?rev=67675&r1=67674&r2=67675&view=diff ============================================================================== --- trunk/iscsi-client/src/IscsiClientLib.ycp (original) +++ trunk/iscsi-client/src/IscsiClientLib.ycp Wed Mar 21 11:58:49 2012 @@ -332,8 +332,7 @@ y2milestone("%1 file exists, create backup", file); SCR::Execute(.target.bash, sformat("mv %1 /etc/iscsi/initiatorname.yastbackup", file)); } - ret = (boolean)SCR::Write (.target.string, file, sformat("InitiatorName=%1\n", new_value)); - SCR::Execute (.target.bash, "chmod 0600 $FILE" ,$["FILE":file]); + ret = (boolean)SCR::Write (.target.string, [file,0600], sformat("InitiatorName=%1\n", new_value)); if (ret){ initiatorname = new_value; y2milestone("Initiatorname %1 written", initiatorname); @@ -565,8 +564,7 @@ initiatorname = ay_settings["initiatorname"]:""; if (size(initiatorname)>0){ string file="/etc/iscsi/initiatorname.iscsi"; - SCR::Write (.target.string, file, sformat("InitiatorName=%1\n", initiatorname)); - SCR::Execute (.target.bash, "chmod 0600 $FILE" ,$["FILE":file]); + SCR::Write (.target.string, [file,0600], sformat("InitiatorName=%1\n", initiatorname)); } else checkInitiatorName(); // start daemon before startIScsid(); -- To unsubscribe, e-mail: yast-commit+unsubscribe@opensuse.org For additional commands, e-mail: yast-commit+help@opensuse.org