Author: jsmeix Date: Wed Jan 20 17:43:53 2010 New Revision: 60464 URL: http://svn.opensuse.org/viewcvs/yast?rev=60464&view=rev Log: Fixed search usability in basicadd.ycp and basicmodify.ycp for ncurses: Only when the user is already searching drivers, set the focus to the InputField for the driver search string so that the user can just continue typing other search strings. In contrast when the user is not already searching drivers, it is annoying in particular in the text-only ncurses UI when the focus becomes always set to the driver search string InputField. Modified: trunk/printer/src/basicadd.ycp trunk/printer/src/basicmodify.ycp Modified: trunk/printer/src/basicadd.ycp URL: http://svn.opensuse.org/viewcvs/yast/trunk/printer/src/basicadd.ycp?rev=60464&r1=60463&r2=60464&view=diff ============================================================================== --- trunk/printer/src/basicadd.ycp (original) +++ trunk/printer/src/basicadd.ycp Wed Jan 20 17:43:53 2010 @@ -295,9 +295,15 @@ _("&Search for") ) ); - // Set the focus to the InputField for the driver search string - // so that the user can just start typing: - UI::SetFocus( `driver_filter_input ); + if( `apply_driver_filter == user_input ) + { // Only when the user is already searching drivers, + // set the focus to the InputField for the driver search string + // so that the user can just continue typing other search strings. + // In contrast when the user is not already searching drivers, + // it is annoying in particular in the text-only ncurses UI + // when the focus becomes always set to the driver search string InputField. + UI::SetFocus( `driver_filter_input ); + } // Wait for user input: user_input = UI::UserInput(); if( `abort == user_input || `cancel == user_input || `back == user_input ) break; Modified: trunk/printer/src/basicmodify.ycp URL: http://svn.opensuse.org/viewcvs/yast/trunk/printer/src/basicmodify.ycp?rev=60464&r1=60463&r2=60464&view=diff ============================================================================== --- trunk/printer/src/basicmodify.ycp (original) +++ trunk/printer/src/basicmodify.ycp Wed Jan 20 17:43:53 2010 @@ -493,9 +493,15 @@ _("&Search for") ) ); - // Set the focus to the InputField for the driver search string - // so that the user can just start typing: - UI::SetFocus( `driver_filter_input ); + if( `apply_driver_filter == user_input ) + { // Only when the user is already searching drivers, + // set the focus to the InputField for the driver search string + // so that the user can just continue typing other search strings. + // In contrast when the user is not already searching drivers, + // it is annoying in particular in the text-only ncurses UI + // when the focus becomes always set to the driver search string InputField. + UI::SetFocus( `driver_filter_input ); + } // Wait for user input: user_input = UI::UserInput(); if( `abort == user_input || `cancel == user_input || `back == user_input ) break; -- To unsubscribe, e-mail: yast-commit+unsubscribe@opensuse.org For additional commands, e-mail: yast-commit+help@opensuse.org