Mailinglist Archive: vhostmd (42 mails)

[Jim Fehlig <jfehlig@xxxxxxxxxx>]

Richard W.M. Jones wrote:
> Jim pointed out another case where there could be a memory leak along
> an error path.  Update patch attached.
>
> GC FTW ...
>
> Rich.
>
>   
> From ea2f772da718adb868150e9c4074ad49f0c374cb Mon Sep 17 00:00:00 2001
> From: Richard Jones <rjones@xxxxxxxxxx>
> Date: Thu, 15 Oct 2009 13:10:18 +0100
> Subject: [PATCH 1/2] Add CONNECT substitution <action>s.
>
> Allow CONNECT to be substituted in any <action>s in order to
> pass the correct libvirt URI down to actions such as virsh.  The
> correct way to run virsh is now:
>
>   virsh -r CONNECT cmd [...]
>
> which substitutes as either:
>
>   virsh -r --connect 'uri' cmd [...]
>
> or:
>
>   virsh -r cmd [...]
>
> Note that you should always run virsh readonly (-r option).
>
> Also corrects the documentation: ID should be VMID.
>
> Also this cleans up the string replacement code and ensures that
> it doesn't leak memory on failure.
> ---
>  docs/man/vhostmd.8 |   24 ++++++++++---
>  vhostmd.xml        |    6 ++--
>  vhostmd/metric.c   |   97 +++++++++++++++++++++++++++++++++++----------------
>  3 files changed, 87 insertions(+), 40 deletions(-)

ACK

Jim
-- 
To unsubscribe, e-mail: vhostmd+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: vhostmd+help@xxxxxxxxxxxx