Re: [radeonhd] xf86-video-radeonhd:master: 3 commit(s)

On Aug 17, 09 23:51:22 -0700, Yang Zhao wrote:

2009/8/17 Frieder Ferlemann :

...

...

    Do not log about "Unknown card detected" when AtomBIOS is available

I do not agree with this change completely. Yes, we have received bad "bug" reports, but if we remove this message we'll probably even get more... More important, your patch removes the logging of the three-hex-numbers string, one that is *very* important for bug reports. Maybe I can rephrase that to looks less provocative.

...

...

    There's a lot of confusion about this message; time to kill it now that     AtomBIOS modesetting is significantly more stable.

I agree that it is pretty weird that the message is encapsuled in #ifdef ATOM_BIOS.

...

Maybe additionally change the text from "Unknown card detected" to "card not found in quirk table" or something like that? AFAIU, without AtomBIOS, we don't have generic modesetting, so any GPU not recognized is effectively unknown. I think it's appropriate to keep this working for this case.

What bites us (again) here is that we do not yet separate between a names list and the quirks table. Matthias -- Matthias Hopf __ __ __ Maxfeldstr. 5 / 90409 Nuernberg (_ | | (_ |__ mat@mshopf.de Phone +49-911-74053-715 __) |_| __) |__ R & D www.mshopf.de -- To unsubscribe, e-mail: radeonhd+unsubscribe@opensuse.org For additional commands, e-mail: radeonhd+help@opensuse.org