Mailinglist Archive: radeonhd (427 mails)

< Previous Next >
Re: [radeonhd] [PATCH]es: Set engine clock after suspend & resume
  • From: Rafał Miłecki <zajec5@xxxxxxxxx>
  • Date: Tue, 19 May 2009 11:00:35 +0200
  • Message-id: <b170af450905190200v11b767dds3556d40160f17ae9@xxxxxxxxxxxxxx>
2009/5/18 Yang Zhao <yang@xxxxxxxxxx>:
2009/5/18 Rafał Miłecki <zajec5@xxxxxxxxx>:
I'm afraid we currently don't restore engine clock on leaving VT
(somehow, it doesn't cause any problems for me). With attached patch
applied I get following output:
(II) RADEONHD(0): Just leaved VT, engine clock is at 168750Hz, default
is 680000Hz

EngineClock seems to stay put after suspend/resume cycles, at least
according to AtomBIOS. I have code that exposes engine and memory
clock as output properties to xrandr. I *think* it's the register
save/restore that's effectively doing the same thing. Not sure if this
is different on a non-r7xx, though.

In case of my M82 (RV620) it doesn't work this way. I don't have
engine clock exported by randr, by simple printing engine clock at end
of RHDEnterVT should make a trick, right?

diff --git a/src/rhd_driver.c b/src/rhd_driver.c
index dd40dcd..e985d67 100644
--- a/src/rhd_driver.c
+++ b/src/rhd_driver.c
@@ -1463,6 +1463,9 @@ RHDEnterVT(int scrnIndex, int flags)
}
#endif

+ xf86DrvMsg(rhdPtr->scrnIndex, X_INFO, "Just entered VT, clock is
now at %ldHz\n",
+ RHDGetEngineClock(rhdPtr));
+
return TRUE;
}

1) Switched to VT1, then VT7, then grep-ped Xorg.0.log
(II) RADEONHD(0): Just entered VT, clock is now at 168750Hz

2) Switched to VT1, then VT7, then grep-ped Xorg.0.log
(II) RADEONHD(0): Just entered VT, clock is now at 168750Hz

3) Switched to VT1, then VT7, then grep-ped Xorg.0.log
(II) RADEONHD(0): Just entered VT, clock is now at 168750Hz

4) s2ram (for my machine it uses -p -m), then grep-ped Xorg.0.log
(II) RADEONHD(0): Just entered VT, clock is now at 675000Hz

5) Switched to VT1, then VT7, then grep-ped Xorg.0.log
(II) RADEONHD(0): Just entered VT, clock is now at 675000Hz

It's actually weird for me that you don't lose engine clock on
suspend&resume. While machine is in suspend mode, only RAM should be
powered, right? That would mean GPU doesn't get power and all
registers are resetted to default values. Maybe suspending on your
machine is broken? Maybe your GPU is still powered?

--
Rafał Miłecki
--
To unsubscribe, e-mail: radeonhd+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: radeonhd+help@xxxxxxxxxxxx

< Previous Next >
Follow Ups