Mailinglist Archive: radeonhd (312 mails)

[Christian König <deathsimple@xxxxxxxxxxx>]

Hi Christiaan,

i have some questions about your RS690 HDMI patch.
First of all could you send me an XOrg log created with -logverbose 7 ?

Second some questions about individual stuff in the patch:

rhd_audio.c:268
} else {
    /* 
     * RS600, RS690, RS730?
     */
    RHDRegWrite(Audio, AUDIO_PLL1_MUL, Rate * 50);
    RHDRegWrite(Audio, AUDIO_PLL1_DIV, Clock * 100);
}

Why do you miss initializing of AUDIO_CLK_SRCSEL and AUDIO_TIMING ?
I think the missing write to AUDIO_TIMING is the problem behind AC3 pass
through not working.

rhd_audio.c:306
} else {
    /*
     * RS600, RS690, RS730?
     */
    if(clear)
        RHDRegWrite(Audio, AUDIO_SUPPORTED_CODEC, codec);
    else
        RHDRegMask(Audio, AUDIO_SUPPORTED_CODEC, codec, codec);
}

Why not setting AUDIO_SUPPORTED_SIZE_RATE ? It's unimportant ATM, but if
somebody tries to load alsa after the radeonhd driver we would ran into
problems.

rhd_hdmi.c:475
case RHD_OUTPUT_UNIPHYA:
case RHD_OUTPUT_UNIPHYB:
case RHD_OUTPUT_KLDSKP_LVTMA:
    /* This part is doubtfull in my opinion */
    RHDRegWrite(hdmi, hdmi->Offset+HDMI_ENABLE, Enable ? 0x110 : 0x0);
    break;

mhm? Why is this doubtful? 0x110 is the value which gets written on M86,
and that also seems to work on anything else.

That's it for the moment, but i think i will have more questions when i
figure out how those additional debug registers you've found works.

Bye,
Christian.

-- 
To unsubscribe, e-mail: radeonhd+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: radeonhd+help@xxxxxxxxxxxx