Mailinglist Archive: radeonhd (312 mails)

[Matthias Hopf <mhopf@xxxxxxx>]

On Apr 08, 09 16:02:16 +0200, Rafał Miłecki wrote:
> 2009/4/8 Matthias Hopf <mhopf@xxxxxxx>:
> > On Apr 07, 09 00:08:55 +0200, Christian König wrote:
> > > Ah, thanks allot, it was giving me quite a headache figuring out what's
> > > going wrong on RS690 for some time now. I will take a look at the patch
> > > and maybe have some additional questions, but that won't be before
> > > Friday.
> >
> > Christian, would it be reasonable to push this into git for the current
> > release, and fix it for good after that, do we want to delay post
> > easter, or ship as is?
>
> Pushing this to master and releasing 1.2.5 the same day? Does this
> patch look to safe for other chipsets (no chance for regression)?

Looks safe to me. Though it needs some work, still.

E.g. there are some typos (RS730 vs. RS740, only in comments, though),
I would prefer >= RHD_R600  instead of > RHD_RS740 (R600 seems to be the
big step, and we might see something like RS760 or RS790 in the future),
there's a comment about a constant that might be wrong in the R600 and
up case (which has to be verified).

Nothing that would hold up a commit. And AFAIK we do not support
pre-R600 HDMI audio correctly yet, am I right?

Matthias

-- 
Matthias Hopf <mhopf@xxxxxxx>      __        __   __
Maxfeldstr. 5 / 90409 Nuernberg   (_   | |  (_   |__          mat@xxxxxxxxx
Phone +49-911-74053-715           __)  |_|  __)  |__  R & D   www.mshopf.de
-- 
To unsubscribe, e-mail: radeonhd+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: radeonhd+help@xxxxxxxxxxxx