Mailinglist Archive: radeonhd (365 mails)

[Alex Deucher <alexdeucher@xxxxxxxxx>]

On Sun, Mar 1, 2009 at 12:42 PM, Christian König
<deathsimple@xxxxxxxxxxx> wrote:
> Hi alex,
>
> the attached patch moves the r600 shaders from r600_exa.c into separate
> files. It also fixes a bunch of typos in the xv pixel shaders (DOT4
> instead of MOV instruction in the 4th ALU instruction), and replaces
> every C++ comment in r600_exa.c with C comments.

Can you split all these changes out as separate patches?  E.g.,
- fix comments
- fix shader typos
- etc.

Also, I think I'd prefer to move the shaders into one file rather a
separate file for each one.

> Bye the way i'm using the r600 shader assembler and disassembler in from
> the ATI stream SDK
> (http://ati.amd.com/technology/streamcomputing/sdkdwnld.html)
> plus a self made awk script to decode/debug the shaders.
>
> This has proven to be quite useful since the result created by the r600
> disassembler is quite more readable than the original c code. I'm
> wondering if we should switch to something more readable instead of
> coding the shaders in C.

Ideally we'd use a shader compiler and we'd write the shaders in glsl
or some other IR, but we don't have one released yet.

Alex
--
To unsubscribe, e-mail: radeonhd+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: radeonhd+help@xxxxxxxxxxxx