Mailinglist Archive: radeonhd (365 mails)
| < Previous | Next > |
Re: [radeonhd] [PATCH] R6xx/R7xx cleanup: Move shaders to seperate files.
- From: Yang Zhao <yang@xxxxxxxxxx>
- Date: Sun, 1 Mar 2009 10:28:15 -0800
- Message-id: <40a7b1aa0903011028p4d9024b3n8d21a6fe43ff4e38@xxxxxxxxxxxxxx>
Hi,
2009/3/1 Christian König <deathsimple@xxxxxxxxxxx>:
Good catch; I missed those entirely.
As for the comments, looks like the assembly-like instructions didn't
make the transition. It's probably a good idea to retain those, as the
macro-driven shader code is extremely hard to parse for a new-comer
otherwise.
Also, IIRC, planar and packed Xv actually uses identical pixel
shaders, so the two can probably be merged into one.
I would also like to suggest grouping the files more logically by
subcomponent and function as opposed to one-per-file.
I reckon that would be part of the shader compiler drop?
Cheers,
--
Yang Zhao
http://yangman.ca
--
To unsubscribe, e-mail: radeonhd+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: radeonhd+help@xxxxxxxxxxxx
2009/3/1 Christian König <deathsimple@xxxxxxxxxxx>:
...It also fixes a bunch of typos in the xv pixel shaders (DOT4
instead of MOV instruction in the 4th ALU instruction)...
Good catch; I missed those entirely.
As for the comments, looks like the assembly-like instructions didn't
make the transition. It's probably a good idea to retain those, as the
macro-driven shader code is extremely hard to parse for a new-comer
otherwise.
Also, IIRC, planar and packed Xv actually uses identical pixel
shaders, so the two can probably be merged into one.
I would also like to suggest grouping the files more logically by
subcomponent and function as opposed to one-per-file.
I'm wondering if we should switch to something more readable instead of
coding the shaders in C.
I reckon that would be part of the shader compiler drop?
Cheers,
--
Yang Zhao
http://yangman.ca
--
To unsubscribe, e-mail: radeonhd+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: radeonhd+help@xxxxxxxxxxxx
| < Previous | Next > |