Mailinglist Archive: radeonhd (307 mails)

< Previous Next >
Re: [radeonhd] Re: [PATCH] Improve wait_vline range
  • From: Alex Deucher <alexdeucher@xxxxxxxxx>
  • Date: Tue, 24 Feb 2009 16:58:40 -0500
  • Message-id: <a728f9f90902241358l3b70e634gd255f46dc22b9fea@xxxxxxxxxxxxxx>
On Tue, Feb 24, 2009 at 4:45 PM, Christian König
<deathsimple@xxxxxxxxxxx> wrote:
Am Dienstag, den 24.02.2009, 00:01 -0800 schrieb Yang Zhao:
This patch introduces a segfault for me due to rhdCrtc->CurrentMode
being NULL. Had to work around it with the following:
Using height is not a god idea, since it is the height of the
framebuffer, not what the crtc is actually scanning out of the
framebuffer (AFAIK). Waiting for a line that's not scanned out can
easyly deadlock the hardware.

Haven't had a chance to figure out why DxModeSet, which sets
CurrentMode, isn't called.
I know why, Active gets set when the Crtc is assigned to ANY connector,
and not if the crtc is active and displaying a picture. You probably
have more than one connector and the monitor isn't connected to the
first one. We are hardcoded waiting on the first one atm, since i
haven't had time yet to figure out on which crtc we are actually
rendering.

@Alex:
Could you push this bugfix (again). I promise not to write patches at
three o'clock in the morning again.

no worries :)

Alex
--
To unsubscribe, e-mail: radeonhd+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: radeonhd+help@xxxxxxxxxxxx

< Previous Next >