Mailinglist Archive: radeonhd (333 mails)

[Matthias Hopf <mhopf@xxxxxxx>]

On Sep 16, 08 23:36:58 +1000, Russell Shaw wrote:
> In RHDPreInit(), there is this code:
>
>   atomBiosArg.fb.start = rhdPtr->FbFreeStart;
>   atomBiosArg.fb.size = rhdPtr->FbFreeSize;
>
>   if(RHDAtomBiosFunc(pScrn->scrnIndex, rhdPtr->atomBIOS,
>           ATOMBIOS_ALLOCATE_FB_SCRATCH, &atomBiosArg) == ATOM_SUCCESS)
>   {
>     rhdPtr->FbFreeStart = atomBiosArg.fb.start;      // line 1
>     rhdPtr->FbFreeSize = atomBiosArg.fb.size;        // line 2
>   }
>
>
> From what i can see, atomBiosArg.fb.start/size are never modified
> in rhdAtomAllocateFbScratch(), so line 1 and 2 are redundant.

RHDAtomBiosFunc might change fb.start/size. And if it doesn't, it could
be that a later implementation does.

CU

Matthias

-- 
Matthias Hopf <mhopf@xxxxxxx>      __        __   __
Maxfeldstr. 5 / 90409 Nuernberg   (_   | |  (_   |__          mat@xxxxxxxxx
Phone +49-911-74053-715           __)  |_|  __)  |__  R & D   www.mshopf.de
-- 
To unsubscribe, e-mail: radeonhd+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: radeonhd+help@xxxxxxxxxxxx