Mailinglist Archive: radeonhd (308 mails)

[Egbert Eich <eich@xxxxxxx>]

Matthias Hopf writes:
> On Feb 28, 08 23:53:42 +0100, Sebastian Redl wrote:
> > In trying to understand a bit how the driver works, I've stumbled upon a
> > bit of unreachable code. In rhd_mc.c line 156ff there is an if:
> >
> >     // line 156:
> >     if (rhdPtr->ChipSet < RHD_R600) {
> >         // ...
> >     // line 174:
> >     } else if (rhdPtr->ChipSet < RHD_R600) {
> >     // ...
>
> gitk shows me this has been changed by Luc...
> Luc, do you know what's up here, and whether the patch is ok?

Actually I've pushed a fix for this.

> > Obviously, the else if case can never be reached.
> >
> > On a side note, I believe the two cases could be merged by putting a few
> > more register offsets into variables, thus reducing code redundancy.

I didn't do the merge as I expect that code will be added for
the individual chipsets.

Cheers,
        Egbert.
-- 
To unsubscribe, e-mail: radeonhd+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: radeonhd+help@xxxxxxxxxxxx