Mailinglist Archive: radeonhd (529 mails)

[bugzilla-daemon@xxxxxxxxxxxxxxx]

http://bugs.freedesktop.org/show_bug.cgi?id=13497





------- Comment #5 from hun@xxxxxxxxxxxxxxxx  2007-12-03 13:02 PST -------
(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)

> > -rhd_conntest_LDADD   = -lz -lpci
> > +rhd_conntest_LDADD   = -lz @PCIUTILS_LIBS@ -lpci
> >
> > Shouldn't this read
> >
> > +rhd_conntest_LDADD   = @PCIUTILS_LIBS@

> I agree with you, that is how it *should* read. However, the libpci.pc file 
> was
> only added as of pciutils 2.2.6, and I was trying to avoid breaking the build
> for people who didn't have this version installed. You'll notice in the
> configure.ac that I let the configure fall through with only a warning when 
> the
> pkg-config lookup for "libpci" fails. It then attempts to still use the same
> method as before to check for pci/pci.h.

OK, if that pkg-config libpci check fails, I now just set PCIUTILS_LIBS="-lpci
-lz" (like libpci.pc does) and proceed with the compile/link check. Then I'll
never get "-lpci -lpci".

This should use libpci.pc if present, and totally fall back to current
behaviour if not.

> If you want to do it now, then go ahead and change the patch to read the more
> appropriate: 
> +rhd_conntest_LDADD   = @PCIUTILS_LIBS@
>
> When the newest pciutils filters its way down, this should work for everybody.
> This change has already made its way into Gentoo portage.

I have submitted your patch and one with my changes to the radeonhd mailing
list.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
_______________________________________________
xorg-team mailing list
xorg-team@xxxxxxxxxxx
http://lists.x.org/mailman/listinfo/xorg-team
-- 
To unsubscribe, e-mail: radeonhd+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: radeonhd+help@xxxxxxxxxxxx