Mailinglist Archive: radeonhd (529 mails)

[bugzilla-daemon@xxxxxxxxxxxxxxx]

http://bugs.freedesktop.org/show_bug.cgi?id=13497





------- Comment #4 from cokane@xxxxxxxxxx  2007-12-03 09:33 PST -------
(In reply to comment #3)
> (In reply to comment #2)
> > Patch to rhd_conntest Makefile.am to use the pkg-config substitutions for
> > libpci
> >
> > Attached the necessary code to have the Makefile.am generate a Makefile for
> > rhd_conntest that will properly source in the substitutions to build the
> > program if libpci is registered in pkg-config's database.
>
> -rhd_conntest_LDADD   = -lz -lpci
> +rhd_conntest_LDADD   = -lz @PCIUTILS_LIBS@ -lpci
>
> Shouldn't this read
>
> +rhd_conntest_LDADD   = @PCIUTILS_LIBS@
>
> ? It is the .pc file's job to know whether or not -lz is needed, and where to
> find the libraries.
>
> I'd be a bit hesitant to add this to radeonhd proper as long as the pciutils
> people actually ship their own .pc file, or the community of package creators
> for all systems agree on what it is supposed to be called like.
>
> If pciutils shipped the .pc file, it would be a no-brainer.
>
> I mean... the CFLAGS/LDFLAGS workaround does work flawlessly, so it's not as 
> if
> this actually prevented you from building radeonhd.

I agree with you, that is how it *should* read. However, the libpci.pc file was
only added as of pciutils 2.2.6, and I was trying to avoid breaking the build
for people who didn't have this version installed. You'll notice in the
configure.ac that I let the configure fall through with only a warning when the
pkg-config lookup for "libpci" fails. It then attempts to still use the same
method as before to check for pci/pci.h.

If you want to do it now, then go ahead and change the patch to read the more
appropriate: 
+rhd_conntest_LDADD   = @PCIUTILS_LIBS@

When the newest pciutils filters its way down, this should work for everybody.
This change has already made its way into Gentoo portage.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
_______________________________________________
xorg-team mailing list
xorg-team@xxxxxxxxxxx
http://lists.x.org/mailman/listinfo/xorg-team
-- 
To unsubscribe, e-mail: radeonhd+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: radeonhd+help@xxxxxxxxxxxx