Mailinglist Archive: radeonhd (529 mails)

[bugzilla-daemon@xxxxxxxxxxxxxxx]

http://bugs.freedesktop.org/show_bug.cgi?id=13497


hun@xxxxxxxxxxxxxxxx changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hun@xxxxxxxxxxxxxxxx




------- Comment #3 from hun@xxxxxxxxxxxxxxxx  2007-12-03 09:18 PST -------
(In reply to comment #2)
> Patch to rhd_conntest Makefile.am to use the pkg-config substitutions for
> libpci
>
> Attached the necessary code to have the Makefile.am generate a Makefile for
> rhd_conntest that will properly source in the substitutions to build the
> program if libpci is registered in pkg-config's database.

-rhd_conntest_LDADD   = -lz -lpci
+rhd_conntest_LDADD   = -lz @PCIUTILS_LIBS@ -lpci

Shouldn't this read

+rhd_conntest_LDADD   = @PCIUTILS_LIBS@

? It is the .pc file's job to know whether or not -lz is needed, and where to
find the libraries.

I'd be a bit hesitant to add this to radeonhd proper as long as the pciutils
people actually ship their own .pc file, or the community of package creators
for all systems agree on what it is supposed to be called like.

If pciutils shipped the .pc file, it would be a no-brainer.

I mean... the CFLAGS/LDFLAGS workaround does work flawlessly, so it's not as if
this actually prevented you from building radeonhd.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
_______________________________________________
xorg-team mailing list
xorg-team@xxxxxxxxxxx
http://lists.x.org/mailman/listinfo/xorg-team
-- 
To unsubscribe, e-mail: radeonhd+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: radeonhd+help@xxxxxxxxxxxx