Mailinglist Archive: opensuse-translation (23 mails)

< Previous Next >
Re: [opensuse-translation] enabling check script
  • From: Gabriel <gabriel@xxxxxxxxxxxx>
  • Date: Wed, 10 Feb 2010 13:17:28 -0300
  • Message-id: <1adde6891002100817q7fa33a9bs6b9786bb9474108d@xxxxxxxxxxxxxx>
On Wed, Feb 10, 2010 at 11:32 AM, Karl Eichwalder <ke@xxxxxxx> wrote:
if len(path) < 3 or path[-3:] != '.po' or base == 'update-desktop-files' or
not changed:

I guess this will not catch files such as:

update-desktop-files-apps.de.po
update-desktop-files-conflicts.de.po
update-desktop-files-directories.de.po
update-desktop-files-kde-services.de.po
update-desktop-files-kde.de.po
update-desktop-files-screensavers.de.po
update-desktop-files-yast.de.po

Here we go--Darix recommends to give re.match a try:


My suggestion is to change the comparision line to:

[code]
if len(path) < 3 or path[-3:] != '.po' or
base.startswith('update-desktop-files') or not changed:
[/code]

strings methods are faster than regexp with single fixed strings.

--
Kind Regards
--
To unsubscribe, e-mail: opensuse-translation+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: opensuse-translation+help@xxxxxxxxxxxx

< Previous Next >
Follow Ups