Mailinglist Archive: opensuse-project (95 mails)

[tabris <tabris@xxxxxxxxxx>]

Cristian Rodriguez wrote:
> tabris escribió:
>
>   
>> I'd like to see this picked up by SuSE, MDV, etc. If you have any
>> comments, please don't hesitate to email me back.
>>
>>     
>
> In about 15 minutes, I packaged your software so it can tested by
> opensuse users, as procinfo-ng with executable name procinfo-ng
>
> here
>
> http://download.opensuse.org/repositories/home:/elvigia/
>
> it will appear as soon at the automated build system finishes it's job.
>
>
>   
Thank you.
> some points:
>
> 1. if you want to get your software into a distribution, it should
> support make install with DESTDIR otherwise it will inmediately annoy
> packagers (the attached patch fixes this problem)
>
> 2. do not assume optimization flags , distributions have their own rules
> for that and respect userland CFLAGS ( patch attached fixes that as well)
>
> 3. tons of compiler warnings. ( patch wont fix that, I let you this work
> ;) )
>   
Hmm. I've been using -Wall and hadn't gotten any compiler warnings. then
agian, I dind't have the define macro, the fmessage-length, or
fstack-protector. So I'll be looking into those when I get a chance.
> g++ -O2 -fmessage-length=0 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector
> -pipe -s procinfo.cpp -o procinfo
> In file included from procinfo.cpp:19:
> routines.cpp: In function 'const std::string uint64toString(const
> uint64_t&)':
> routines.cpp:87: warning: format '%llu' expects type 'long long unsigned
> int', but argument 4 has type 'long unsigned int'
> routines.cpp:87: warning: format '%llu' expects type 'long long unsigned
> int', but argument 4 has type 'long unsigned int'
> routines.cpp: In function 'const std::string int64toString(const int64_t&)':
> routines.cpp:93: warning: format '%lld' expects type 'long long int',
> but argument 4 has type 'long int'
> routines.cpp:93: warning: format '%lld' expects type 'long long int',
> but argument 4 has type 'long int'
> procinfo.cpp: In function 'std::vector<std::basic_string<char,
> std::char_traits<char>, std::allocator<char> >,
> std::allocator<std::basic_string<char, std::char_traits<char>,
> std::allocator<char> > > > renderPageStat(bool, bool, double, const
> uint64_t&, const std::string&)':
> procinfo.cpp:344: warning: format '%15llu' expects type 'long long
> unsigned int', but argument 4 has type 'uint64_t'
> procinfo.cpp:344: warning: format '%15llu' expects type 'long long
> unsigned int', but argument 4 has type 'uint64_t'
> procinfo.cpp: In function 'std::string renderIRQ(bool, bool, const
> double&, const IRQ&, const uint64_t&)':
> procinfo.cpp:469: warning: format '%llu' expects type 'long long
> unsigned int', but argument 4 has type 'uint64_t'
> procinfo.cpp:469: warning: format '%llu' expects type 'long long
> unsigned int', but argument 4 has type 'uint64_t'
> procinfo.cpp: In function
> 'std::vector<std::vector<std::basic_string<char, std::char_traits<char>,
> std::allocator<char> >, std::allocator<std::basic_string<char,
> std::char_traits<char>, std::allocator<char> > > >,
> std::allocator<std::vector<std::basic_string<char,
> std::char_traits<char>, std::allocator<char> >,
> std::allocator<std::basic_string<char, std::char_traits<char>,
> std::allocator<char> > > > > > renderDiskStats(bool, bool, bool, const
> double&, const std::vector<diskStat_t, std::allocator<diskStat_t> >&)':
> procinfo.cpp:589: warning: format '%15llu' expects type 'long long
> unsigned int', but argument 5 has type 'long unsigned int'
> procinfo.cpp:589: warning: format '%15llu' expects type 'long long
> unsigned int', but argument 6 has type 'long unsigned int'
> procinfo.cpp:589: warning: format '%15llu' expects type 'long long
> unsigned int', but argument 5 has type 'long unsigned int'
> procinfo.cpp:589: warning: format '%15llu' expects type 'long long
> unsigned int', but argument 6 has type 'long unsigned int'
>
>
> that's all , have fun ;)
>
>
>