On Thursday 2015-11-26 14:04, Petr Tesarik wrote:
I see. I probably shouldn't have accepted submitrequest 325452 back
It also added "BuildRequires: libtool >= 2", because (presumably) autoreconf failed otherwise. That part made the package unresolvable in SLE10 (which only ships libtool-1.5).
I think I now why. libkdumpfile-fallback-for-old-zlib.patch changes configure.ac, which means autoreconf should ideally be rerun, since patching autogenerated files like "configure" can end in a rebase horror. Since configure.ac uses LT_INIT, this prescribes libtool >= 2. The simple way out would be to just substitute LT_INIT with AC_PROG_LIBTOOL in the same libkdumpfile-fallback-for-old-zlib.patch patch, so that you will be able to BuildRequire: libtool >= 1.5. -- And you still can drop the ugly hunks for the generated configure script, since you now have the ability to rebuild configure.ac->configure with the old litool.
Anyway, while trying to make it build again, I wondered if there was any policy on this topic and I found this macro:
https://en.opensuse.org/openSUSE:Packaging_Conventions_RPM_Macros#.25suse_up...
I checked a few packages that use autoconf, but none of them was using this macro, but some of them used autoreconf. At this point I was unsure if I'm supposed to use that macro (as suggested by the above-mentioned page), run it unconditionally (like some packages do)
The macro is somewhat obscure, probably in a way that's sanctioned or not supported elsewhere/upstream, so most people run autoreconf, also because the age of in-distro autotools packages is not as bad as it might have used to be 15 years ago. That, and/or we now have enough automagic masters who know how to make a package work across multiple autotools versions - see for example the libtool 1.5 approach proposed above.
run it only on recent distros (like some other packages do), or ignore it and just run %configure (like most packages do).
configure may find a reason to regenerate itself, and then ignoring won't work. -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org