On Wed, 25 Mar 2015 15:06, Cristian Morales Vega
I have been very little active for a while.
I have SR#290195 changing
Source0: https://github.com/LMMS/lmms/archive/v%{version}.tar.gz for Source0: https://github.com/LMMS/lmms/archive/%{name}-%{version}.tar.gz
Since the new version has been created in the author's machine through git. The thing is that https://github.com/LMMS/lmms/archive/%{name}-%{version}.tar.gz doesn't exist.
There will be some source service (download_files?) in openSUSE:Factory that will complain?
And what's the current policy about this? a) The SR is OK b) If upstream offers a tarball, even if with a weird name, it must be used c) It's acceptable to use "git archive" like this, but fake URLs are not. Just use "Source0: %{name}-%{version}.tar.gz" d) None of the others
Looking at "https://github.com/LMMS/lmms/releases" shows that the source tar.gz files reside under the "v%{version}.tar.gz" name. As this is the "offical" upstream, I'd keep the "real" upstream name. Otherwise, one can not really build this package from the spec file. IMHO, if there is a outside link and not just a local archive, the outside link should be in direct usable format, even if that means honouring "weird" naming schemes. Here, either the "real" url, or the "localized" archive. Or both, with one of them commented out. Longterm, the real url helps more, esp. between multiple maintainers. That's my 2ct. - Yamaban. -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org