On Sunday, April 07, 2013 12:03:10 Lars Vogdt wrote:
Hi Andi
Andreas Jaeger
schrieb: I don't see this guideline as a law but as guidance. So, let's talk about exceptions. And if you have a suggestion for a better wording then please propose one.
As we have many guidelines for our packages, but less "laws", I always follow this direction when I review packages for factory:
* submission violates the law: reject (including hint or URL as reason)
* submission violates the guideline: accept (including hint or URL to the guideline asking to think about for next submission)
* submission does not violate anything above, but I have a bad feeling: ask other reviewers - or discuss directly with the packager. In worst case: reject
* submission does not violate anything above, but I have a hint for the packager: accept, including my hint
* …
My feeling is now that I am not a good reviewer as I accept too many packages. My hope is/was that packagers read my comments even if their package gets accepted for Factory. If this assumption is wrong, we should discuss what I can do instead.
There's always a line for interpretation - e.g. if the guidelines get updated, I would not enforce it necessarily for old submissions.
Currently I do not like the idea to reject packages because of guideline violations, but if my notes are not read if I accept a package, than I should adapt to a better strategy. Suggestions welcome!
I might be a bit more willing to reject submissions but IMO it's important to know that review is not final - if anybody disagrees with the review, reopening the request and adding a comment or mailing me directly is always fine. I see a challenge with the notes if A submits to a devel projects, B accepts and forwards it - will A get your note - or only B? Packagers, are these review notes helpfull - or should we direct directly? Andreas -- Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg) GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126 -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org