On 01/10/2013 02:41 PM, Marcus Hüwe wrote:
Hi,
On 2013-01-10 10:22:52 +0100, Sascha Peilicke wrote:
<SNIP>
Even though you end up with four OBS packages, you only have to modify / fix "python-nose" due to the links. This is much better than using copypac (as I've seen recently). Of course you should only split up into several spec files if there's a very good reason for the extra work. Here are some:
- To avoid build cycles - To off-load looong-running parts of a package build, like: + Running a testsuite ($PACKAGE-testsuite.spec) + Building documentation ($PACKAGE-doc.spec)
Hmm I don't think it's a good idea to move the run of a testsuite or the doc building to different spec files because it might decrease the "quality" of a package. For instance: - the package is pushed to the repo even if the testsuite fails Agreed, that could happen. Still better than not running the testsuite at all :-)
- the package and package-doc might be inconsistent (if the package is pushed to the repo and the doc building fails) I agree, but a failed doc build is usually less of an issue than if the complete package build fails. However, if you want a good example where it makes sense to split, check the build requirements of
https://build.opensuse.org/package/view_file?expand=1&file=openstack-nova.spec&package=openstack-nova&project=Cloud%3AOpenStack%3AMaster versus https://build.opensuse.org/package/view_file?expand=1&file=openstack-nova-doc.spec&package=openstack-nova&project=Cloud%3AOpenStack%3AMaster
IMHO it's probably better to comment out the long running parts (or define some macros for them) when doing local builds.
Running the testsuite only locally doesn't guarantee it's working on the build host either.
- When building the same thing against a different set of (build) requirements, like: + Different $DYNAMIC_LANGUAGE interpreter versions (usually $INTERPRETER-$PACKAGE.spec)
Thanks for the pointers!
Marcus
-- With kind regards, Sascha Peilicke SUSE Linux GmbH, Maxfeldstr. 5, D-90409 Nuernberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer HRB 16746 (AG Nürnberg)