Mailinglist Archive: opensuse-packaging (267 mails)
| < Previous | Next > |
Re: [opensuse-packaging] What can I do to resolve these items in a RPMLINT report
- From: Dimstar / Dominique Leuenberger <dimstar@xxxxxxxxxxxx>
- Date: Mon, 12 Dec 2011 15:59:01 +0100
- Message-id: <1323701941.2774.8.camel@3120-3560.ams.tmf-group.com>
On Tue, 2011-12-13 at 01:48 +1100, doiggl@xxxxxxxxxxxxxxxxxx wrote:
This is the critical one killing your build. It's a remainder from
patching the source (either by you or by upstream, and pakcaging it).
Simply delete the offending file and be set.
The files are not marked executable, but have a shebang. It seems to be
common assumption that any perl or python file needs a shebang. Clearly
wrong :) If the file is not meant to be executed on its own: remove the
first line (discuss with upstream... they might take patches)
Not fatal, jusst a warning: a config file generally belogns to /etc
or /var, as noted above. A 'clean' solution would be to move the file
to /etc and link it from your package source. Then you can properly mark
the config file as %conf, have it in /etc and the code still finds it.
You'd have to check though if PHP likes following file links (needs to
be a softlink in this case)
You have a comment in your spec file (a line staring with #) which
contains %macros. This might or might not do what you expect. Generally,
macros are also expanded in rpm comments. Depending on what the macro
does, it might change your spec or build. to be sure, double the percent
sign in comments.
FSF moved. Update the address. Co-ordinate with upstream
As stated in the comment: .htaccess should better be handled by apache
config files that are being included. Easier to manage and maintain. But
then: it's a warning, non fatal.
Hope to get you over your errors warning and have given you sufficient
information. Otherwise just ask again.
Dominique
--
To unsubscribe, e-mail: opensuse-packaging+unsubscribe@xxxxxxxxxxxx
To contact the owner, e-mail: opensuse-packaging+owner@xxxxxxxxxxxx
Hello,
What can I do to resolve these items in a RPMLINT report [1]
Thanks Glenn
RPMLINT report:
===============
(none): E: badness 10000 exceeds threshold 1000, aborting.
cacti.noarch: E: suse-filelist-forbidden (Badness: 10000)
/usr/share/cacti/lib/functions.php.orig is not allowed in SUSE
Your package installs files or directories in a location that have
previously
been blacklisted. Please have a look at the particular file and see if the
SUSE Packaging Guidelines propose a better place on where to install the
file
or not install it at all.
This is the critical one killing your build. It's a remainder from
patching the source (either by you or by upstream, and pakcaging it).
Simply delete the offending file and be set.
cacti.noarch: W: non-executable-script
/usr/share/cacti/scripts/unix_processes.pl 0644L /usr/bin/perl
cacti.noarch: W: non-executable-script
/usr/share/cacti/cli/add_data_query.php 0644L /usr/bin/php
cacti.noarch: W: non-executable-script
/usr/share/cacti/scripts/3com_cable_modem.pl 0644L /usr/bin/perl
cacti.noarch: W: non-executable-script /usr/share/cacti/scripts/ping.pl
0644L /usr/bin/perl
cacti.noarch: W: non-executable-script
/usr/share/cacti/cli/data_template_associate_rra.php 0644L /usr/bin/php
cacti.noarch: W: non-executable-script /usr/share/cacti/cli/add_graphs.php
0644L /usr/bin/php
cacti.noarch: W: non-executable-script
/usr/share/cacti/scripts/diskfree.pl 0644L /usr/bin/perl
cacti.noarch: W: non-executable-script /usr/share/cacti/scripts/loadavg.pl
0644L /usr/bin/perl
cacti.noarch: W: non-executable-script
/usr/share/cacti/scripts/unix_users.pl 0644L /usr/bin/perl
cacti.noarch: W: non-executable-script
/usr/share/cacti/scripts/diskfree.sh 0644L /bin/sh
cacti.noarch: W: non-executable-script
/usr/share/cacti/cli/analyze_database.php 0644L /usr/bin/php
cacti.noarch: W: non-executable-script
/usr/share/cacti/scripts/weatherbug.pl 0644L /usr/bin/perl
cacti.noarch: W: non-executable-script
/usr/share/cacti/cli/add_graph_template.php 0644L /usr/bin/php
cacti.noarch: W: non-executable-script /usr/share/cacti/cli/add_perms.php
0644L /usr/bin/php
cacti.noarch: W: non-executable-script
/usr/share/cacti/scripts/loadavg_multi.pl 0644L /usr/bin/perl
cacti.noarch: W: non-executable-script /usr/share/cacti/cli/add_device.php
0644L /usr/bin/php
cacti.noarch: W: non-executable-script /usr/share/cacti/scripts/webhits.pl
0644L /usr/bin/perl
cacti.noarch: W: non-executable-script
/usr/share/cacti/scripts/linux_memory.pl 0644L /usr/bin/perl
cacti.noarch: W: non-executable-script /usr/share/cacti/cli/add_tree.php
0644L /usr/bin/php
cacti.noarch: W: non-executable-script
/usr/share/cacti/scripts/query_unix_partitions.pl 0644L /usr/bin/perl
cacti.noarch: W: non-executable-script
/usr/share/cacti/scripts/unix_tcp_connections.pl 0644L /usr/bin/perl
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.
If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.
The files are not marked executable, but have a shebang. It seems to be
common assumption that any perl or python file needs a shebang. Clearly
wrong :) If the file is not meant to be executed on its own: remove the
first line (discuss with upstream... they might take patches)
cacti.noarch: W: non-etc-or-var-file-marked-as-conffile
/usr/share/cacti/include/config.php
A file not in /etc or /var is marked as being a configuration file. Please
put
your conf files in /etc or /var.
Not fatal, jusst a warning: a config file generally belogns to /etc
or /var, as noted above. A 'clean' solution would be to move the file
to /etc and link it from your package source. Then you can properly mark
the config file as %conf, have it in /etc and the code still finds it.
You'd have to check though if PHP likes following file links (needs to
be a softlink in this case)
cacti.src:93: W: macro-in-comment %{prefix}
There is a unescaped macro after a shell style comment in the specfile.
Macros
are expanded everywhere, so check if it can cause a problem in this case
and
escape the macro with another leading % if appropriate.
You have a comment in your spec file (a line staring with #) which
contains %macros. This might or might not do what you expect. Generally,
macros are also expanded in rpm comments. Depending on what the macro
does, it might change your spec or build. to be sure, double the percent
sign in comments.
cacti.noarch: W: incorrect-fsf-address
/usr/share/doc/packages/cacti/LICENSE
The Free Software Foundation address in this file seems to be outdated or
misspelled. Ask upstream to update the address, or if this is a license
file,
possibly the entire file with a new copy available from the FSF.
FSF moved. Update the address. Co-ordinate with upstream
cacti.noarch: W: htaccess-file /usr/share/cacti/cli/.htaccess
cacti.noarch: W: htaccess-file /usr/share/cacti/rra/.htaccess
You have individual apache configuration .htaccess file(s) in your
package.
Replace them by a central configuration file in /etc/, according to the
web
application packaging policy for your distribution.
As stated in the comment: .htaccess should better be handled by apache
config files that are being included. Easier to manage and maintain. But
then: it's a warning, non fatal.
cacti.noarch: W: files-duplicate /usr/share/cacti/cli/.htaccess
/usr/share/cacti/rra/.htaccess
cacti.noarch: W: backup-file-in-package
/usr/share/cacti/lib/functions.php.orig
You have a file whose name looks like one for backup files, usually
created by
an editor or resulting from applying unclean (fuzzy, or ones with line
offsets) patches.
Hope to get you over your errors warning and have given you sufficient
information. Otherwise just ask again.
Dominique
--
To unsubscribe, e-mail: opensuse-packaging+unsubscribe@xxxxxxxxxxxx
To contact the owner, e-mail: opensuse-packaging+owner@xxxxxxxxxxxx
| < Previous | Next > |