On Tue, 6 Dec 2011, Stephan Kulow wrote:
On 06.12.2011 10:01, Vincent Untz wrote:
Le lundi 05 décembre 2011, à 18:05 +0100, Stephan Kulow a écrit :
On 05.12.2011 15:33, Stephan Kulow wrote:
On 05.12.2011 14:21, Richard Guenther wrote:
Minus the vertical space issue, the Name: mangling and the toplevel comment removal then changes look good. But I obviously cannot apply a patch like the one produced.
Richard and me debugged this a bit more and we came up with a compromise :)
As I implemented all features wanted from replies, I would like to reformat all factory sources. What I would like to do:
- release the current git version as update
- reformat all factory packages that are unchanged branches in the devel package
The main goal is to change the license to spdx format so we can enable the rpmlint error about non-spdx license format.
So would you restrict the change to the license, or run the whole thing?
I'm fine with the former, less sure about the latter if we don't review the changes somewhere (although fixing 3000 packages and breaking by accident 2 obscure packages might be a fine compromise).
I can tell you from experience - if you review 1000 packages, 2 obscure packages will slip through anyway as your eyes create a filter for whitespace after ~50 packages :)
Which is why devel project owners should do the review ;) Richard. -- Richard Guenther <rguenther@suse.de> SUSE / SUSE Labs SUSE LINUX Products GmbH - Nuernberg - AG Nuernberg - HRB 16746 GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer