Mailinglist Archive: opensuse-packaging (205 mails)

< Previous Next >
Re: [opensuse-packaging] Specfile Guidelines sweep over Factory
Am 19.09.2011 12:25, schrieb Vincent Untz:
Le lundi 19 septembre 2011, à 12:23 +0200, Jan Engelhardt a écrit :
On Monday 2011-09-19 12:22, Vincent Untz wrote:

Hi,

Le lundi 19 septembre 2011, à 02:44 +0200, Jan Engelhardt a écrit :
automated:
- removal of '# norootforbuild'
- removal of 'AutoReqProv: on' since this is default anyway
manual:
- removal of Authors list, no longer desired in factory
- removal of %clean section, no longer required
- removal of rm -Rf %buildroot in %install when spotted, [1]
- changing %{?%jobs:-j%jobs} to %_smp_mflags, [1]
- adding %{?_smp_mflags} whereever there is none, or
- tagging places more explicitly where parallel build does not work
by utilizing the grepable string "-j1" plus a comment if none exists
- replacing CFLAGS="$RPM_OPT_FLAGS" ./configure --bindir=%_bindir
--infodir=%_infodir ... (and similar) by %configure [shorter]
- shlib policy where it seems quick
- killing old %changelog (because it's in .changes already)

I didn't know it was doing all that :-)

Just wondering: is this based on spec-cleaner? Most of this is done by
spec-cleaner (although it doesn't remove %clean right now, iirc).

What part of the word "manual" was imprecise?

The part where it was not visible to me since it's in the middle of a
rather big list, I guess.

In that case, did you consider re-using spec-cleaner for this? It can be
trimmed down to do only the changes you're looking at.

BTW, I tried spec-cleaner the first time now and immediately had to
revert at least one thing.
%makeinstall -> %make_install
this is NOT available on SLE11 (and most likely 11.1).

Where to file bugs about it? Or is it desired behaviour?


Wolfgang
--
To unsubscribe, e-mail: opensuse-packaging+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: opensuse-packaging+help@xxxxxxxxxxxx

< Previous Next >