Mailinglist Archive: opensuse-packaging (205 mails)
| < Previous | Next > |
Re: [opensuse-packaging] Specfile Guidelines sweep over Factory
- From: Juergen Weigert <jw@xxxxxxx>
- Date: Mon, 19 Sep 2011 11:22:42 +0200
- Message-id: <20110919092242.GM8806@suse.de>
On Sep 19, 11 10:36:41 +0200, Jan Engelhardt wrote:
Ouch, this is a horrible mess!
No. This needs a Specfile_guideline, saying that %if-%else-%endif
must not reach across sections.
Then, the cleanup-script will happily break those specfiles,
that violate the guidelines.
cheers,
JW-
--
o \ Juergen Weigert paint it green! __/ _=======.=======_
<V> | jw@xxxxxxx back to ascii! __/ _---|____________\/
\ | 0911 74053-508 __/ (____/ /\
(/) | _____________________________/ _/ \_ vim:set sw=2 wm=8
SUSE LINUX Products GmbH, GF: Jeff Hawn, J.Guild, F.Imendoerffer, HRB 16746
(AG Nuernberg), Maxfeldstrasse 5, 90409 Nuernberg, Germany
SuSE. Supporting Linux since 1992.
--
To unsubscribe, e-mail: opensuse-packaging+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: opensuse-packaging+help@xxxxxxxxxxxx
[1] http://en.opensuse.org/openSUSE:Specfile_guidelines
manual:
- removal of %clean section, no longer required
Not really; I figured that many of the changes are context-sensitive and
would require extensive scripting. Take for example this one:
%clean
rm -rf foo
%if 0%{?sles_version}
%files
...
%else
%files
...
%endif
Ouch, this is a horrible mess!
Since %if is resolved before %clean, one would need a static
analyzer-like tool (work, work, work) and walk all possible paths to
determine just how far the %clean section goes.
No. This needs a Specfile_guideline, saying that %if-%else-%endif
must not reach across sections.
Then, the cleanup-script will happily break those specfiles,
that violate the guidelines.
cheers,
JW-
--
o \ Juergen Weigert paint it green! __/ _=======.=======_
<V> | jw@xxxxxxx back to ascii! __/ _---|____________\/
\ | 0911 74053-508 __/ (____/ /\
(/) | _____________________________/ _/ \_ vim:set sw=2 wm=8
SUSE LINUX Products GmbH, GF: Jeff Hawn, J.Guild, F.Imendoerffer, HRB 16746
(AG Nuernberg), Maxfeldstrasse 5, 90409 Nuernberg, Germany
SuSE. Supporting Linux since 1992.
--
To unsubscribe, e-mail: opensuse-packaging+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: opensuse-packaging+help@xxxxxxxxxxxx
| < Previous | Next > |