Mailinglist Archive: opensuse-packaging (205 mails)

[Jan Engelhardt <jengelh@xxxxxxxxxx>]

On Monday 2011-09-19 09:14, Robert Schweikert wrote:

> On 09/18/2011 08:44 PM, Jan Engelhardt wrote:
> > vuntz mentioned it might be good to inform people, though I doubt anyone
> > is going to read this..
>
> Don't be so pessimistic ;)
>
> > As you may have noticed I am going through all factory packages to
> > implement a few of the specfile guidelines[1] in semi-automated fashion,
> > among them the following subtasks:
> >
> >    [1] http://en.opensuse.org/openSUSE:Specfile_guidelines
> >
> > automated:
> > - removal of '# norootforbuild'
> > - removal of 'AutoReqProv: on' since this is default anyway
> > manual:
> > - removal of Authors list, no longer desired in factory
> > - removal of %clean section, no longer required
> > - removal of rm -Rf %buildroot in %install when spotted, [1]
> > - changing %{?%jobs:-j%jobs} to %_smp_mflags, [1]
> > - adding %{?_smp_mflags} whereever there is none, or
> > - tagging places more explicitly where parallel build does not work
> >   by utilizing the grepable string "-j1" plus a comment if none exists
> > - replacing CFLAGS="$RPM_OPT_FLAGS" ./configure --bindir=%_bindir
> >   --infodir=%_infodir ... (and similar) by %configure [shorter]
> > - shlib policy where it seems quick
> > - killing old %changelog (because it's in .changes already)
>
> Thanks for doing this clean up work.
>
> If you have a script it might be nice to run this over the devel projects as
> well or make it available such that devel project maintainers can use it.

Not really; I figured that many of the changes are context-sensitive and 
would require extensive scripting. Take for example this one:

%clean
rm -rf foo
%if 0%{?sles_version}

%files
...
%else
%files
...
%endif

Since %if is resolved before %clean, one would need a static 
analyzer-like tool (work, work, work) and walk all possible paths to 
determine just how far the %clean section goes.
-- 
To unsubscribe, e-mail: opensuse-packaging+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: opensuse-packaging+help@xxxxxxxxxxxx