On Wednesday 25 August 2010 13:31:16 Frederic Crozat wrote:
Le mercredi 25 août 2010 à 13:22 +0200, Ludwig Nussel a écrit :
Vincent Untz wrote:
I'm considering patching rpmlint to add errors when those macros are not used. See the attached patch, which I haven't tested yet.
I'm a bit worried that adding tons of checks like this will be expensive in the long term. On the other hand, missing those calls is really bad since it will result in non-working packages or even crashing applications.
There are more expensive tests than those anyways so don't worry. The rpmlint package already carries way too much patches though. If your tests are SUSE specific anyways it would probably make sense to have it in a separate file here: http://gitorious.org/opensuse/rpmlint-checks
If the macros are suse specific I wonder how other distros solve the problem?
With my "previous" Mandriva hat :
macros were used, similar to Vincent proposal, until file triggers were added to Mandriva RPM (I think there is work to add them to upstream RPM too), which was doing the work in the background ;)
We try to avoid trigger scripts, because it can lead to the situation that package X is not installable or de-instable, because package Y has a broken script. This is highly confusing and can make debugging a nightmare. bye adrian
While adding macros for gtk/glib, shouldn't we also add a macro for icon cache regeneration (like in Mandriva) ?
-- Adrian Schroeter SUSE Linux Products GmbH email: adrian@suse.de -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org