Mailinglist Archive: opensuse-packaging (53 mails)

< Previous Next >
Re: [opensuse-packaging] some "interesting" rpmlint warnings
  • From: Cristian Rodríguez <crrodriguez@xxxxxxx>
  • Date: Sun, 20 Jul 2008 17:40:26 -0400
  • Message-id: <4883B0CA.2000707@xxxxxxx>
Christian Boltz escribió:
Hello,

I found some "interesting" rpmlint warnings with my package "patch2mail" in home:cboltz.

patch2mail.noarch: W: explicit-lib-dependency libxslt
You must let rpm find the library dependencies by itself. Do not put unneeded explicit Requires: tags.

that's right, Require /usr/bin/xsltproc instead, the package that contains /usr/bin/xsltproc may be renamed at anytime and will break yours ! ;, I have checked out your package, there is a patch attached with some cleanups ;-)

patch2mail.noarch: W: missing-dependency-to-cron for logrotate script /etc/cron.daily/patch2mail
This package installs a file in /etc/logrotate.d/ or in /etc/cron.*/ but doesn't require cron to be installed. as cron is not part of the essential packages, your package should explicitely require cron to make sure that your logrotate or cron job is executed.

Hmm, what's wrong with my Requires: line? It already includes cron...
Requires: bash mktemp mail grep zypper coreutils net-tools cron libxslt


That may be a bug.. probably Dirk knows about it..


"A computer is like an Old Testament god, with a lot of rules and no mercy. "

Cristian Rodríguez R.
Platform/OpenSUSE - Core Services
SUSE LINUX Products GmbH
Research & Development
http://www.opensuse.org/

Index: patch2mail.spec
===================================================================
--- patch2mail.spec (revision 18)
+++ patch2mail.spec (working copy)
@@ -16,7 +16,7 @@
Summary: Patch notification via mail
BuildArch: noarch

-Requires: bash mktemp mail grep zypper coreutils net-tools cron libxslt
+Requires: mktemp mail grep zypper coreutils net-tools cron
/usr/bin/xsltproc
# detailed requirements:
# zypper # (>= 11.0) zypp-refresh-rapper, zypper
# zypper # (<= 10.3) zypp-checkpatches-wrapper
@@ -33,17 +33,17 @@
Christian Boltz < p a c k a g e s AT c b o l t z DOT d e >

%prep
-%setup
+%setup -q

%build

%install
-%{__mkdir} -p %{buildroot}/usr/share/%{name}
+%{__mkdir} -p %{buildroot}%{_datadir}/%{name}
%{__mkdir} -p %{buildroot}/etc/cron.daily

-%{__cp} patch2mail.xsl %{buildroot}/usr/share/%{name}/
+%{__cp} patch2mail.xsl %{buildroot}%{_datadir}/%{name}/
%if 0%{?suse_version} < 1030
- %{__cp} patch2mail.xsl_10.2
%{buildroot}/usr/share/%{name}/patch2mail.xsl
+ %{__cp} patch2mail.xsl_10.2
%{buildroot}%{_datadir}/%{name}/patch2mail.xsl
%endif

%{__cp} patch2mail %{buildroot}/etc/cron.daily/
@@ -56,12 +56,13 @@
echo ================================

%clean
+rm -rf %{buildroot}

%files
%defattr(-,root,root)
%attr(755, root, root) /etc/cron.daily/%{name}
-/usr/share/%{name}/
-/usr/share/%{name}/%{name}.xsl
+%{_datadir}/%{name}/
+%{_datadir}/%{name}/%{name}.xsl
%doc README

%changelog

< Previous Next >
References