Mailinglist Archive: opensuse-packaging (102 mails)

< Previous Next >
Re: [opensuse-packaging] Please criticise my spec file.
  • From: Cristian Rodriguez <crrodriguez@xxxxxxx>
  • Date: Sat, 01 Sep 2007 21:18:03 -0400
  • Message-id: <46DA0F4B.8040905@xxxxxxx>
Paul Elliott escribió:

> -------------------cut here with a chainsaw--------------------
> # norootforbuild
> %define _prefix   /opt/gnome


uh ho. GNOME has moved to /usr

> %{?suse_update_config:BuildRequires:autoconf automake libtool}
> %{?suse_update_libdir:%{suse_update_libdir}}
> %{?suse_update_config:%{suse_update_config -f}}

If you really need what those macros do, create a patch instead.


> %install
> rm -rf $RPM_BUILD_ROOT

nope. you should not do that.

> %changelog
> * Fri Aug 31 2007 Paul Elliott <pelliott@xxxxxx> - 1.156-17
> - add intltool, gcc-c++

use the changes file instead.


-- 
Cristian Rodríguez R. SUSE R&D
"You don't have to burn books to destroy a culture. Just get people to
stop reading them." --Ray Bradbury
---------------------------------------------------------------------
To unsubscribe, e-mail: opensuse-packaging+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: opensuse-packaging+help@xxxxxxxxxxxx

< Previous Next >
List Navigation
References