-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 3/8/15 5:01 AM, Jean Delvare wrote:
Hi Jeff, Andreas,
On Sat, 07 Mar 2015 13:04:30 -0500, Jeff Mahoney wrote:
On 3/4/15 10:30 AM, Andreas Färber wrote:
Am 03.03.2015 um 21:40 schrieb Jeff Mahoney:
bh1780gli - SENSORS_BH1780 - enabled on arm64, armv6hl, armv7hl, i386, ppc, ppc64, ppc64le, x86_64 - buggy? has an i2c device table but it's not exported
For armv6hl (i.e., Raspberry Pi) I went through and enabled all I2C and SPI sensors just recently. I obviously did not check them for presence of the module table macro line - can you or Jean send a patch to add that?
Jean, since you're much more involved with i2c, could you take a look at this?
I've just sent a patch adding the missing MODULE_DEVICE_TABLE to the bh1780gli driver: http://marc.info/?l=linux-kernel&m=142580461109630&w=2
Note that DT/OF-based systems are not affected, and this does not prevent the driver from being used on the other systems either, all that is missing is module auto-loading. But I couldn't find any piece of kernel code instantiating this device anyway, so the only case where it would make a difference is if someone instantiates the device manually from user-space through sysfs.
Huh. Ok. Shows how much I know about how the i2c subsystem works. Is it the case that there are probably a bunch of drivers like this that would never be loaded on e.g. x86 systems? - -Jeff - -- Jeff Mahoney SUSE Labs -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) iQIcBAEBAgAGBQJU/NY9AAoJEB57S2MheeWyCEwP/27F9fJFVDB1aLxwZCGim4rV KSrxHf1DQX/zSaySKuyP5XAxDq+QXzr97GscCe9wt5jYdhCStsv+Rhs2PVy2WJzl ff+c05E8NgOG490Jq8qdYooa6MRB31Giv3nKVD117knDNaWJTUeg6283VPekvfau O3KnEpySXpr9buUIUauQsqCca8xmoqXOg1+e/U+4kK6+fydPOUKRr+2jFmeMnDZO xTbyQVpcmXYHiB28Ki2Z0j+zb/mH37y0bSdTmECY/12tmLVTdBFukS2o+RaYxjHD 9UYZbbNbLtL6/vuhF/ofrG3QkvC4TTKaP4+VMxdJ+Inv/0oSAhJ+Z/u8nx0c2+fm w0CPLJh6q1jPWnlWJLeOF6IqDKn0YXXdGIBFJaBBZA61oBroSUHBiPD8QwJbmHSK fvHbAytODyzMykrImdDGpVQIS3HNeTbzD9nsb08UuJmL8ppfqgk81RJ2ynzZXd5s bUS3T/fEl1v8LrPcTUFQTujm3+tgEICKnYpuZHNdETb7R/jS9wP5uPMVoe9Rq5Hi xldSutC04e1SRJhtPdPk5xCb+dx7/TONyhX1XBGTpKqCJRnXUFUfBqeytE6PQNRI M+0drWZ4LQNgmIZgJtIunsH+lR/qct5ieIy0pJUvD8Vf8HUTPL0nvucjyLPEgC+7 IxnLkSoC1X+b7V3OgkdG =EgOJ -----END PGP SIGNATURE----- -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org