On Wed, 2012-06-27 at 06:56 +0200, Mike Galbraith wrote:
On Wed, 2012-06-27 at 00:11 -0400, Jeff Mahoney wrote:
On 6/27/12 12:07 AM, Mike Galbraith wrote:
On Tue, 2012-06-26 at 23:17 -0400, Jeff Mahoney wrote:
On 6/26/12 5:18 PM, Jiri Slaby wrote:
On 06/25/2012 01:10 PM, Marcus Meissner wrote:
We are getting lots of bugreports that the current 12.1 kernel update breaks suspend to ram.
bnc#764864 and lots of duplicates.
We should be fine by now...
I'm afraid not. This is an issue severe enough that we revoked a maintenance update and I don't see a mention of that bnc (or related) in the changelog. I'm not going to push it as a maintenance update until there's a entry in the changelog with a bugzilla reference that shows the casual user that this problem has been fixed.
Is this the relevant fix? If so, please document it.
Aw poo, no bug reference, and not verbose enough. Yeah, removing the dud patch is the fix. Hm, so to properly document, edit kernel-source.changes and push again, or revert and redo from scratch?
All the options suck. In 12.1, kernel-source.changes isn't used anymore. The changelog is generated from the git log. Since it's the top commit, I wonder if git commit --amend will work or if it'll break things since you've already pushed. If that works, it'd be ideal. Otherwise, a "previous commit did xyz (bnc#...)" commit will probably be the cleanest.
If that's now acceptable, I'll try to push.
commit cd12a46f207e18f4d4e4c3ca6a670a12ed848c84 Author: Mike Galbraith
Date: Tue Jun 26 05:31:23 2012 +0200 This commit fixes suspend to ram breakage reported in bnc#764864.
Remove dud patch. The problem it addressed is being respun upstream, is in tip, but not yet mainlined. See bnc#752460 for details regarding the problem the now removed patch fixed while breaking S2R.
Delete patches.fixes/cpusets-Dont-touch-cpusets-during-suspend-or-resume.patch.
Hm.. strange. git commit --amend followed by git log, shows one commit
with amended log. Perfect. Then git pull, one becomes two commits each
doing the same thing per git show.
I'm not at all sure what this will do if I push it.
commit d0160785c29429447c2e479c977d5e07dab7b40a
Merge: 1e8509b 254aa61
Author: Mike Galbraith