On Tue, Jun 12, Jan Beulich wrote:
While I questioned whether doing this (for a slim boot time benefit this might provide) is really the right thing already in the past, bug 766284 points out another reason why this is a bad idea. Can this be reverted (in master and 12.2 at least)?
The change below for ata_piix (and other related changes in April 2009) was made without a bugzilla or fate reference. Whats the practical benefit of having the drivers built into the kernel? At least ata_piix should be a module because it also drives emulated hardware (not only in a Xen HVM guest). Olaf -- commit bdee7838da3086dd3da2083cdaad544700fda143 Author: Greg Kroah-Hartman <gregkh@suse.de> Date: Fri Jun 19 17:12:03 2009 -0700 - Update config files. config/i386/pae and config/x86-64/default: CONFIG_ATA_PIIX=Y diff --git a/config/i386/pae b/config/i386/pae index b88a7e7..778202f 100644 --- a/config/i386/pae +++ b/config/i386/pae @@ -1611,7 +1611,7 @@ CONFIG_SATA_AHCI=y CONFIG_SATA_SIL24=m CONFIG_ATA_SFF=y CONFIG_SATA_SVW=m -CONFIG_ATA_PIIX=m +CONFIG_ATA_PIIX=y CONFIG_SATA_MV=m CONFIG_SATA_NV=m CONFIG_PDC_ADMA=m diff --git a/config/x86_64/default b/config/x86_64/default index c9b9486..b1b2211 100644 --- a/config/x86_64/default +++ b/config/x86_64/default @@ -1568,7 +1568,7 @@ CONFIG_SATA_AHCI=y CONFIG_SATA_SIL24=m CONFIG_ATA_SFF=y CONFIG_SATA_SVW=m -CONFIG_ATA_PIIX=m +CONFIG_ATA_PIIX=y CONFIG_SATA_MV=m CONFIG_SATA_NV=m CONFIG_PDC_ADMA=m diff --git a/kernel-source.changes b/kernel-source.changes index 2e1e6fb..b0a8c8d 100644 --- a/kernel-source.changes +++ b/kernel-source.changes @@ -1,4 +1,11 @@ ------------------------------------------------------------------- +Sat Jun 20 02:11:50 CEST 2009 - gregkh@suse.de + +- Update config files. + config/i386/pae and config/x86-64/default: + CONFIG_ATA_PIIX=Y + +------------------------------------------------------------------- Sat Jun 20 02:09:25 CEST 2009 - gregkh@suse.de - Update config files. -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org