Mailinglist Archive: opensuse-kernel (33 mails)

[Larry Finger <Larry.Finger@xxxxxxxxxxxx>]

On 05/17/2010 04:26 AM, Jiri Benc wrote:
> On Thu, 06 May 2010 13:39:47 -0500, Larry Finger wrote:
> > V2 - Fix a typo, and reference a wiki page rather than the forum.
>
> Sorry for the long delay. I was in the middle of applying the patch
> when I noticed two other things:
>
> Spaces at the end/beginning of the individual lines in the string are
> not correct. Not a big deal, easy to fix while applying.
>
> However, "If you do not have Internet access, go to this URL" sounds
> strange.
>
> How about this?
>
> ---
> Subject: b43: Change firmware missing message to refer to openSUSE script
> From: Larry Finger <Larry.Finger@xxxxxxxxxxxx>
> Patch-mainline: never
>
> The error message output by b43 contains instructions for obtaining
> firmware; however, this naturally does not take account of the script
> /usr/sbin/install_bcm43xx_firmware. Modify the messages to suggest use
> of the script.
>
> Signed-off-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx>
> Modified-by: Jiri Benc <jbenc@xxxxxxx>
> Signed-off-by: Jiri Benc <jbenc@xxxxxxx>
>
> ---
>  drivers/net/wireless/b43/main.c |   11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)
>
> --- linux-2.6.33-master.orig/drivers/net/wireless/b43/main.c
> +++ linux-2.6.33-master/drivers/net/wireless/b43/main.c
> @@ -1976,10 +1976,13 @@ static void b43_release_firmware(struct 
>  static void b43_print_fw_helptext(struct b43_wl *wl, bool error)
>  {
>       const char text[] =
> -             "You must go to " \
> -             "http://wireless.kernel.org/en/users/Drivers/b43#devicefirmware 
> " \
> -             "and download the correct firmware for this driver version. " \
> -             "Please carefully read all instructions on this website.\n";
> +             "Please open a terminal and enter the command " \
> +             "\"sudo /usr/sbin/install_bcm43xx_firmware\" to download " \
> +             "the correct firmware for this driver version. " \
> +             "For an off-line installation, go to " \
> +             "http://en.opensuse.org/HCL/Network_Adapters_(Wireless)/" \
> +             "Broadcom_BCM43xx and follow the instructions in the " \
> +             "\"Installing firmware from RPM packages\" section.\n";
>  
>       if (error)
>               b43err(wl, text);

Jiri,

That sounds great. Thanks,

Larry
-- 
To unsubscribe, e-mail: opensuse-kernel+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: opensuse-kernel+help@xxxxxxxxxxxx