Mailinglist Archive: opensuse-kernel (109 mails)

[Jean Delvare <jdelvare@xxxxxxx>]

On Sunday 07 March 2010 04:35:12 pm Jeff Mahoney wrote:
> On 03/06/2010 02:21 PM, Jan Engelhardt wrote:
> > Avoid old MUTEX macros and use sema instead, which works
> > for both default and RT kernels.
>
> No.
>
> They aren't the "old MUTEX macros", they're used *everywhere* in the
> regular kernel. If the RT kernel doesn't implement them, that's a bug in
> the RT kernel, not novfs.

Err, no, DECLARE_MUTEX is for the old semaphore-backed-up mutexes, this _is_ 
old and deprecated and fortunately almost unused at this time, except in 
staging drivers. I would love to see it die once and for all to remove all the 
remaining confusion. Definitely something for the kernel-janitors project.

> There was quite a bit of effort put into replacing semaphore sites with
> mutexes a while ago. Where a while ago is defined as about 4 years ago.
> Replacing a mutex with a semaphore when the required behavior is mutual
> exclusion is, quite simply, a regression.

This is totally correct, but irrelevant here. Jan's patch was essentially 
expanding macros, not changing the data structure types.

-- 
Jean Delvare
Suse L3
-- 
To unsubscribe, e-mail: opensuse-kernel+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: opensuse-kernel+help@xxxxxxxxxxxx