Mailinglist Archive: opensuse-kde (249 mails)
| < Previous | Next > |
Re: [opensuse-kde] KDE_VERSION_STRING in kdelibs4, is the release number *really* needed?
- From: Cristian Morales Vega <cmorve69@xxxxxxxx>
- Date: Sat, 24 Apr 2010 12:12:39 +0200
- Message-id: <v2v8235e6f41004240312rcaccbddaqb961b07b413ff590@xxxxxxxxxxxxxx>
2010/4/22 Cristian Morales Vega <cmorve69@xxxxxxxx>:
Since I was thinking this the wrong way, to make it clearer...
that it generates differences in other packages that depend on it.
If we remove the *full* release number from KDE_VERSION_STRING:
- There will be no differences for kdelibs4 itself. If the spec file
is changed the package will get rebuilt and published, and that will
trigger the rebuild of dependent packages.
- Dependent packages will get rebuilt, but what we gain is that they
will not be published if there is no need. Right now they are
published if the generated binaries depend on the KDE_VERSION_STRING
value (at least every app with an About box)
So there is no gain in build power (perhaps in "second level"
dependencies), only in bandwidth.
Without a better way, I created SR #38665 with:
if [ '%{_project}' != KDE:KDE4:Factory:Desktop -a \
'%{_project}' != KDE:KDE4:UNSTABLE:Desktop -a \
'%{_project}' != KDE:KDE4:STABLE:Desktop -a \
'%{_project}' != openSUSE:Factory ] ; then
sed -ri "s,#cmakedefine KDE_VERSION_STRING
\"@KDE_VERSION_STRING@\",#cmakedefine KDE_VERSION_STRING
\"@KDE_VERSION_STRING@ \\\\\"release $(echo %release | cut -d.
-f-1)\\\\\"\"," kdecore/util/kdeversion.h.cmake
fi
--
To unsubscribe, e-mail: opensuse-kde+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: opensuse-kde+help@xxxxxxxxxxxx
2010/4/22 Dirk Müller <dmueller@xxxxxxx>:
the kernel-source spec files strip away the rebuild counter. I think this
would
globally solve the issue as well.
I didn't found the strip in the kernel-source spec. But removing the
rebuild counter we solve the problem when a rebuild is triggered
because of a change in a third library. But it could still happen that
somebody changes the kdelibs4 spec file without causing any effect in
the generated binaries. If you remove the rebuild counter you remove
the problem for rebuilds. But to remove the problem for new releases
the full release number needs to be removed from KDE_VERSION_STRING.
Since I was thinking this the wrong way, to make it clearer...
From a start the KDE_VERSION_STRING contained the release number**without** the rebuild counter. The only real problem with this is
that it generates differences in other packages that depend on it.
If we remove the *full* release number from KDE_VERSION_STRING:
- There will be no differences for kdelibs4 itself. If the spec file
is changed the package will get rebuilt and published, and that will
trigger the rebuild of dependent packages.
- Dependent packages will get rebuilt, but what we gain is that they
will not be published if there is no need. Right now they are
published if the generated binaries depend on the KDE_VERSION_STRING
value (at least every app with an About box)
So there is no gain in build power (perhaps in "second level"
dependencies), only in bandwidth.
Without a better way, I created SR #38665 with:
if [ '%{_project}' != KDE:KDE4:Factory:Desktop -a \
'%{_project}' != KDE:KDE4:UNSTABLE:Desktop -a \
'%{_project}' != KDE:KDE4:STABLE:Desktop -a \
'%{_project}' != openSUSE:Factory ] ; then
sed -ri "s,#cmakedefine KDE_VERSION_STRING
\"@KDE_VERSION_STRING@\",#cmakedefine KDE_VERSION_STRING
\"@KDE_VERSION_STRING@ \\\\\"release $(echo %release | cut -d.
-f-1)\\\\\"\"," kdecore/util/kdeversion.h.cmake
fi
--
To unsubscribe, e-mail: opensuse-kde+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: opensuse-kde+help@xxxxxxxxxxxx
| < Previous | Next > |