-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Denny Beyer wrote:
| Any help is appreciated. And I hope java software packaging is getting
more
| popular and we will have more java software available soon on OBS :-)
|
| Thanks for your help on cleaning up the file.
| I started the section on Java packaging, as there wasn't anything yet
and I
| found a number of Java packages in opensuse aren't actually "build" -
as such
| during the packaging process.
Well personally, I don't see the point of "always building".
It's JVM bytecode. It's portable. No point in building (except to make
sure it compiles and runs with JDK 1.4 if 1.4 is all you have and you
don't trust upstream saying it runs with 1.4).
| Look at the "Jarnal" build script in Factory ;-)
|
| [...]
|> I had a quick look at it, fixed some spelling and rewrote parts of the
|> spec file (e.g. never "rm -rf $RPM_BUILD_ROOT" except in the %clean
|> section).
| Why not? I cleans the directory before building ... not really necessary
| anymore with OBS though...
It's a potential race condition that can be used to delete directories
as root when someone replaces the $RPM_BUILD_ROOT directory with a
symlink to, say, /
;)
Furthermore, it isn't needed at all, as rpmbuild already takes care of
doing so properly (and without the race).
| Also, a few questions remain:
| Why did you replace all the {name} variables with the actual name?
|
| What is better in using "%__install ..." over "install ..." ?
%__install is more portable.
On some platforms (e.g. AIX), a capable "install" binary might not be
"install" but "ginstall" or "/usr/local/bin/install" (instead of
"/usr/bin/install") or "/opt/gnu/install" etc...
It's not very likely that the packages would be rebuilt on a non-Linux
platform but if so, the tools can be configured properly through the
rpmmacros file.
Personally, when there's a macro, I use the macro.
| "$RPM_BUILD_ROOT" has been replaced with "%{buildroot}" too, any
advantage
| here?
None, besides using the macro instead of the environment variable.
Just a matter of taste on this one.
cheers
- --
~ -o) Pascal Bleser