Mailinglist Archive: opensuse-features (365 mails)

< Previous Next >
[openFATE 120373] Unified Button Labels
  • From: fate_noreply@xxxxxxx
  • Date: Tue, 2 Mar 2010 15:46:49 +0100 (CET)
  • Message-id: <feature-120373-56@xxxxxxxxxxxxxx>
Feature changed by: Christoph Thiel (cthiel1)
Feature #120373, revision 56
Title: Unified Button Labels

openSUSE-10.3: Rejected by Stephan Kulow (coolo)
reject date: 2007-07-30 10:43:50
reject reason: not enough resources to do it right
Priority
Requester: Desirable
Projectmanager: Important

openSUSE-11.0: Rejected by Stanislav Visnovsky (visnov)
reject date: 2009-03-30 09:27:47
reject reason: Did not happen completely in time.
Priority
Requester: Mandatory
Projectmanager: Important

openSUSE-11.2: Rejected by Christoph Thiel (cthiel1)
reject date: 2009-07-16 11:08:56
reject reason: out of resources for 11.2.
Priority
Requester: Desirable

openSUSE-11.3: Evaluation
Priority
Requester: Desirable
+ Projectmanager: Important

Requested by: Klaus Kämpf (kwk)

Description:
Unify button labels
YaST currently uses several different button labels for basically the
same action, i.e. 'Ok', 'Accept', and 'Finish'.
Decision: Only a single label per action should be used. Labels should
be generally "OK" and "Cancel" for standard modules and "Back", "Next",
"Cancel" and "Finish" for wizards.

Documentation Impact:
check YaST descriptions in manuals and update screen shots

Discussion:
#1: Gerald Pfeifer (geraldpfeifer) (2006-06-27 11:36:42)
I'm moving this from "future" to 10.3. 10.2 will share much with SP1,
so we cannot make this kind of change there. Adding Coolo and Edith for
usability and YaST, respectively.

#2: Tanja Roth (ta-ro) (2007-06-11 16:37:21)
This would also have documentation impact - we would have to check the
YaST parts of the manuals and to redo a lot of screen shots, I guess.

#3: Jiri Srain (jsrain) (2007-07-26 14:27:21)
I don't think that we can solve this issue now, this must start being
solved at the beginning of release cycle. Please, move to 11.0.

#4: Stephan Kulow (coolo) (2007-11-20 11:48:19)
the release cycle of 11.0 just started. Please kill Reject and Accept
soonish.
If I may add here: please do not overuse Ok and Cancel, but rather use
explicit actions where appliying.
"Do not delete 11 files? Ok/Cancel" is no-go, Delete/Cancel helps the
user much more.

#5: Jiri Srain (jsrain) (2008-03-10 13:36:56) (reply to #4)
I don't think that such cases can be handled a different way than on
the per-case basis as bugreports.

#6: Jiri Srain (jsrain) (2008-03-10 13:39:16)
This is the list of files which contain the Accept or Reject words
(probably not complete and probably some of the files are superfluous
due to non-perfect regext). Please, get rid of as many as possible of
them.
./add-on/src/add-on_proposal.ycp
./add-on/src/inst_language_add-on.ycp
./apparmor/src/include/subdomain/reporting_archived_dialogs.ycp
./apparmor/src/include/subdomain/reporting_utils.ycp
./dhcp-server/src/dns-server-wizard.ycp
./fingerprint-reader/src/users_plugin_fingerprint_reader.ycp
./firewall/src/dialogs.ycp
./firewall/src/subdialogs.ycp
./ftp-server/src/complex.ycp
./ftp-server/src/dialogs.ycp
./inetd/src/dialogs.ycp
./installation/src/clients/inst_network_setup.ycp
./installation/src/clients/inst_proposal.ycp
./kdump/src/dialogs.ycp
./kerberos-client/src/dialogs.ycp
./ldap-client/src/LdapPopup.ycp
./ldap-client/src/ui.ycp
./live-installer/src/inst_live_simple_proposal.ycp
./ncurses-pkg/src/pkg_layout.ycp
./network/src/lan/complex.ycp
./nis-client/src/ui.ycp
./ntp-client/src/dialogs.ycp
./packager/doc/display_driver_popup.ycp
./packager/src/clients/inst_packages.ycp
./packager/src/clients/inst_productsources.ycp
./printer/src/common/dialogs.ycp
./registration/src/modules/Register.ycp
./restore/src/ui.ycp
./runlevel/src/runlevel_proposal.ycp
./samba-server/src/ldap-widget.ycp
./sound/sound/src/complex.ycp
./squid/src/complex.ycp
./storage/storage/src/inst_custom_part.ycp
./storage/storage/src/inst_prepdisk.ycp
./storage/storage/src/modules/StorageControllers.ycp
./system-update/src/system-update.ycp
./tune/hwinfo/src/newid.ycp
./tune/hwinfo/src/system_settings_dialogs.ycp
./update/src/clients/system_update.ycp
./update/src/clients/update.ycp
./update/src/include/rootpart.ycp
./users/src/dialogs.ycp
./users/src/users_plugin_ldap_all.ycp
./users/src/users_plugin_ldap_passwordpolicy.ycp
./users/src/users_plugin_ldap_shadowaccount.ycp
./users/src/users_plugin_quota.ycp
./yast2/library/modules/Label.ycp
./yast2/library/wizard/src/Wizard.ycp
./ycp-ui-bindings/examples/Wizard2.ycp

#7: Martin Schmidkunz (mschmidkunz) (2008-03-10 17:18:59)
Cool!
When we are already touching the navigation buttons maybe we can also
try to work out feature #303446 "Button order, positioning, labeling in
YaST".
Button order should be according to the selected desktop. If another
desktop then KDE or GNOME is selected either KDE or GNOME button order
should be used.
The help button should be aligned left and the navigation buttons
should be aligned right. Having too much space between the navigation
buttons as we have no doesn't support grouping of buttons, which makes
navigation difficult for the user.
Labeling should be as stated in this feature.

#8: Ladislav Slezak (lslezak) (2008-03-17 16:51:45)
Fixed in yast2-sound-2.16.4, yast2-tune-2.16.0 and in yast2-packager-
2.16.27

#9: Arvin Schnell (aschnell) (2008-03-18 17:25:40)
Is the decision documented in some style-guide?

#10: Martin Schmidkunz (mschmidkunz) (2008-03-19 12:10:05)
It is documented in http://en.opensuse.org/Image:Ysg.pdf However this
is just a first draft which needs to be approved (FATE: 303041)

#11: Jiří­ Suchomel (jsuchome) (2008-03-26 10:55:07)
Done in yast2-ldap-client, yast2-fingerprint-reader, yast2-kerberos-
client, yast2-nis-client, yast2-users

#12: Jozef Uhliarik (juhliarik) (2008-03-27 10:18:07)
Fixed in yast2-kdump-2.16.10, yast2-ftp-server-2.16.10 and in yast2-
dhcp-server-2.16.7

#13: Arvin Schnell (aschnell) (2008-03-27 16:40:31)
Done for storage.

#14: J. Daniel Schmidt (jdsn) (2008-04-01 11:51:50)
In case of registration the word "Reject" is used in context of a
certificate. The user is asked to "Trust" or "Reject" the certificate.
Changing it to "Trust" and "No" or to change the question and switch to
"Yes"/"No" is not quite intuitive I think. So I'd keep the word
"Reject" for registration. Btw: It will appear never in openSUSE but
only during manual installation of a SLE product with registering
agains a registration proxy aka. SMT.

#15: Katarina Machalkova (kmachalkova) (2008-04-04 10:43:39)
And what about installation proposals and installation clients? Are we
suppose to substitute word "Accept" by something else there, too? If
so, what is the suitable word in such case? Clearly not "Finish" (as it
may let user think that it will finish the whole installation), is "OK"
the right one then?

#16: Martin Schmidkunz (mschmidkunz) (2008-04-04 11:21:54)
What about using "Next"?

#17: Jiri Srain (jsrain) (2008-04-04 10:51:20) (reply to #16)
Next sounds to me like another step in a workflow should follow, which
is not this case. I personally prefer simple "OK".

#18: Lukas Ocilka (locilka) (2008-04-04 12:25:58) (reply to #17)
I personally still prefer "Accept" as it was in the previous YaST Style
Guide TM. But "OK" might work too. "Next" is definitely _not_ the right
way to go. We have to distinguish between the main workflow and the
step-workflows.

#19: Martin Schmidkunz (mschmidkunz) (2008-04-04 12:33:28) (reply to
#18)
Why is it necessary to distinguish between main workflow and steps
workflow? To the user it is just one installation process. Just out of
curiosity: why is accepting the proposal not considered just another
step in the installation workflow? basic settings => accepting proposal
=> perform installation

#20: Lukas Ocilka (locilka) (2008-04-04 12:52:04) (reply to #19)
For accepting the installation proposal, I'd even rather use [Install]
than anything else. [Accept] has been used there because it's so
important decision that in needs emphasizing.

#21: Jiri Srain (jsrain) (2008-04-04 11:55:21) (reply to #19)
Katarina's question was about the button e.g. in the partitioning
dialog, not about the installation proposal as whole (if I understood
it correctly).

#22: Martin Schmidkunz (mschmidkunz) (2008-04-04 14:19:14) (reply to
#21)
Sorry for the misunderstanding and thanks for the correction!
I suggest to use Cancel/OK as the only two buttons. Reason: the dialogs
are side-steps from main installation workflow.
I think now I got Lukas' comment about main worklfow and steps-
workflow. :-)

#23: Katarina Machalkova (kmachalkova) (2008-04-04 17:23:36) (reply to
#21)
Right, the partitioning dialog (or networking, gfx card, whatever) that is
launched from installation proposal. For example, in yast2-network, we
use (in the very same dialog) "Finish" on running system, but "Accept"
in installation. My q. was whether to substitute the installation
client's "Accept" button with something more suitable.

#24: Lukas Ocilka (locilka) (2008-04-11 18:23:12)
Changing Accept buttons to Install or Update (FATE #120373) >> yast2-
installation-2.16.34

#25: Lukas Ocilka (locilka) (2008-04-11 18:45:41)
Done in yast2-update-2.16.6
This is definitely going to break something as I can't check every
change made...

#26: Jiri Srain (jsrain) (2008-04-14 11:40:57)
Most of the Accept/Reject buttons are gone now. Let's solve the
remaining ones as bugs.

#31: Michael Löffler (michl19) (2009-06-09 15:39:44) (reply to #26)
Jiri, how much work needs to be done to clean it up by 100%?

#27: Martin Schmidkunz (mschmidkunz) (2009-03-18 16:23:14)
It is true that the Accept and Reject button labels are removed from
the YaST modules. However the button labels are far from being unified.
The biggest mess ist the crude mixture of "Cancel" and "Abort" labels
and the second issue is the presentation of "Back" buttons which have
the same functionality as "Cancel" but are shown in one screen
configuration dialogs. The attempt to solve these issues via bugzilla
(https://bugzilla.novell.com/show_bug.cgi?id=478089) revealed that this
issue seems to aquire some ressources. One main reason for button
labeling trouble seems to be that wizard.ycp is used in many places
where the dialog is not a wizard, but where it is an overview.
To get a professional, consistent GUI and in order to reduce
translation efforts and development of new YaST modules one possible
solution might be the development of two different templates:
* * wizard.ycp for wizards and installation and
* * overview.ycp for edit/singe configuration/overview dialogs
Some possible layouts can be viewed at:
* http://en.opensuse.org/Image:Wizard_dialog.png
* http://en.opensuse.org/Image:Overview_dialog.png
Buttons could use something like the button box widget developed sh or
the button label widget developed by mzugec.
As mentioned in the bug, it will take some effort and ressources but I
think, that the outcomes will be worth it!

#30: Martin Schmidkunz (mschmidkunz) (2009-04-01 15:39:33)
The status of button labels in YaST (based on openSUSE 11.1/SLE 11) can
be found at: http://en.opensuse.org/Media:Unified_buttons_yast.pdf
Some basic numbers:
* * 10 different button combinations for overview dialogs
* * 5 different button combinations for wizard dialogs
* * 3 different button combinations for progress dialogs
Suggestions for a unification:
* Use Cancel/OK for overview dialogs
* Use Cancel/OK and Back/Cancel/Next (Back/Cancel/Finish) for wizards
* Cancel for progress dialogs
Necessary work for unified buttons in overview dialogs
* Cancel/OK is already used in 28 of 78 overview dialogs
* 50 overview dialogs which need adjustments (4 x relabeling 2 buttons,
9 x relabeling 1 button, 12 x hide 1 button, 25 x hide 1 Button and
relabeling 2 buttons)
Necessary work for unified buttons in wizard dialogs
* Cancel/OK and Back/Cancel/Next are already used in 23 of 44 overview
dialogs
* 21 wizard dialogs which need adjustments (20 x relabeling 1 button, 1 x
add “Cancel” button)
Necessary work for unified buttons in progress dialogs
* Cancel is already used in 3 of 46 progress dialogs
* All progress dialogs can be easily adjusted by hiding “Back” and
“Next” buttons and relabel “Abort” into “Cancel” in progress.ycp
Final conclusions/questions
* Unified button labels in wizards and progress dialogs can be achieved
by just adjusting wizard.ycp and progress.ycp libraries
* Overview dialogs need some manual adjustments as they base on wizards.
ycp as well
* Can adjustments be done by copying code from existing dialogs with
OK/Cancel buttons (e.g. Date and Time)?
* Does it make sense to invest into an overview.ycp dialog?


#32: Roman Bysh (romanator) (2010-01-24 23:56:12)
This is long overdue and should be considered. If not in 11.3, it
should be for 12.0.



--
openSUSE Feature:
https://features.opensuse.org/120373

< Previous Next >
This Thread