On 07/08/2016 05:58 PM, Joaquín Yeray Martín de la Nuez wrote:
Hi,
On Thursday, July 7, 2016 11:19:40 AM WEST Ancor Gonzalez Sosa wrote:
Hi Joaquin,
First of all, thanks for the effort. The module is looking fine so far. Good work!
Now, the "not so nice" part. :-)
I tested the module and found some usability quirks. I would be interested in other people opinion:
* It was kind of surprising to me that selecting a choice or setting the alternative to automatic immediately closed the modal dialog. For me it was expected. But I also expected some kind the "Set choice" to be selected by default (so I could just hit "enter" to select the option). This is because you only have 2 possible actions, and only can execute one. So at first I thought that is enough to simply close the dialog. But maybe see
First thanks to you for try the module and give some feedback. They are good suggestions, only a note with the first one, you can see it below. the changes and then press "Ok" is a good way. It would be nice know more opinions.
I can live with the current approach of immediately closing the window if you fix the lost of the focus (and scroll) when going back to the alternatives list. If fact, is the combination of both things which annoys me. :-) And the focus issue has already been pointed by two other users.
* Initial focus on "search" is kind of strange in ncurses (although having a bad initial focus on ncurses is almost a YaST trend :-) ). I don't have a strong opinion about that. But yes, I would expect the focus in the list.
* After changing an alternative (and thus closing the modal dialog) the focus in the list of alternatives is again in the first item of the list. I expect that kind of listing reloading in a web page, but it feels weird for a desktop application. +1
* Cancel should alert that changes will be lost. +1
* The header of the choices table reads "alternative" instead of "choice".
* I expected that selecting a choice and pressing enter (in ncurses) our double clicking on it (in Qt) would set that choice, but I need to use the "Set choice" button. +1 (as I said before). For me pressing enter in ncurses should set the choice and close the dialog.
As said, just my view. I would like to know what other people has to say.
Cheers. On the other hand, nice work!
Regards, Imo
Cheers -- Ancor González Sosa YaST Team at SUSE Linux GmbH -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org