On 10/02/2016 21:17, Tomas Chvatal wrote:
Dave Plater píše v St 10. 02. 2016 v 20:37 +0200:
On 10/02/2016 13:20, Tomas Chvatal wrote:
As per $SUBJ we are trying to phase out the obs-service- format_spec_file which has a lots of bugs on complex packages (huge preamble definitions). Ie. binutils have to keep hacks to actually pass the format_spec_file run. I'm interested, what does obs-service-format_spec_file actually do wrong. It changes the date in the opensuse header, and minor changes to the ordering of the spec. Your package on the other hand prevented me from getting blender to factory with it's %ifarch conditional intact and commanded me to use the %cmake macro. I use spec cleaner once on new spec files when I wish, I don't want something a radical as spec cleaner touching my spec files on checkin without any warning.
Dave that is the key for the minimal mode. It does not add those fixmes and most of the intrusive changes.
It breaks too often on parsing the header. In the bug mentioned in previous mail you have checklist of what format_spec_file tries to do.
Cheers
Tom
A bit of positive feedback, I created a new package today from a PCLinuxOS src rpm and spec cleaner helped speed up the process. Regards Dave P -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org