Hello, Am Mittwoch, 27. Mai 2015 schrieb Petr Gajdos:
On Wed, May 27, 2015 at 02:20:16PM +0200, Marcus Rueckert wrote:
Note that for deprecated names we provide compat symlinks there, but not for all of removed names. If you think there should be more compat symlinks, please let me know.
all binary names should be kept. you dont want to break things like puppet/chef/... and spec files depending on those things without need. Done. See the new sr#308921 and new file list diff.
Much better (and basically what I told you on IRC already ;-) BTW: -/usr/share/apache2/find_httpd2_includes +/usr/share/apache2/find_httpd_includes Besides the question if there should be a compat symlink for this, the script itsself looks buggy ;-) for i in $found; do case $i in *\**) # filter filenames that are unexpanded, in the lack of a match, # like /etc/apache2/conf.d/*.conf ;; *) conffiles="$conffiles $i" find_include_files $i ;; esac done This can fail for at least two reasons: a) someone might really use a filename like foo*.conf (with a literal *) and the code above would filter it out. (Yes, I know that it might be a good idea to blame the person who created a file with such a name ;-) b) apache also supports ? as wildcard (commonly used for "don't explode if the include file doesn't exist"), and the script doesn't filter for that The better and easier solution is a simple test -f "$i" which will give you the correct result regardless of the filename. Oh, and I don't really want to know what happens - for filenames with spaces (quotes? spliting $found and $conffiles again?) - on circular / recursive includes ;-) Regards, Christian Boltz --
Programmieren in C++ hält die grauen Zellen am Leben. Es schaerft alle fuenf Sinne: den Schwachsinn, den Bloedsinn, den Wahnsinn, den Unsinn und den Stumpfsinn. [Felix von Leitner und Holger Veit in doc]
-- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org