Re: [opensuse-factory] openSUSE LXDM them for LXDE proposal

On Monday 12 May 2014 12.14:03 lynn wrote:

On Mon, 2014-05-12 at 11:11 +0200, Guido Berhoerster wrote:

...

* jcsl [2014-05-11 19:27]:

...

I've been working on a new theme for LXDM, the display manager of LXDE. You can see it at

http://susepaste.org/7512082

From top to bottom you can see 1) user selection with the users list visible, 2) user selection without the users list visible and 3) the password prompt. I'd like it to be included in the next openSUSE version, and in the meantime I could add it to the lxdm package if I'm allowed.

Don't add openSUSE-specific branding directly to the lxdm package, instead create a new package lxdm-branding-openSUSE and put your theme in there. Then add a subpackage lxdm-branding-upstream to the lxdm specfile and move the upstream theme files into that subpackage. Finally you need to fix up dependencies so that lxdm requires either one of the branding packages. Basically it needs to look like this:

lxdm.spec: [...] Requires: %{name}-branding = %{version} [...] %package branding-upstream Summary: Upstream branding of %{name} Group: System/X11/Displaymanagers Requires: %{name} = %{version} Provides: %{name}-branding = %{version} Conflicts: otherproviders(%{name}-branding) Supplements: packageand(%{name}:branding-upstream) BuildArch: noarch #BRAND: <explain the branding files here>

%description branding-upstream This package provides the upstream look and feel for %{name}.

lxdm-branding-openSUSE.spec: [...] %define lxdm_version %(rpm -q --queryformat '%%{version}' lxdm) [...] BuildRequires: lxdm [...] Requires: lxdm = %{lxdm_version} Provides: lxdm-branding = %{lxdm_version} Conflicts: otherproviders(lxdm-branding) Supplements: packageand(lxdm:branding-openSUSE) [...] %description This package provides the openSUSE look and feel for %{name}.

This should be documented at https://en.opensuse.org/openSUSE:Packaging_guidelines#Branding but it isn't.

Aw, what a pity:(

Lynn you mean: Thanks Guido for this excellent template which respect so nicely the way the things have to be done :-) -- Bruno Friedmann Ioda-Net Sàrl www.ioda-net.ch openSUSE Member & Board GPG KEY : D5C9B751C4653227 irc: tigerfoot ~~~Don't take Life too serious. Nobody gets out alive anyway!~~~ -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org