On Sam, 2013-05-04 at 17:05 +0200, Marcus Rueckert wrote:
[[[ - Fix build with automake 1.13 ]]]
is really better than
[[[ - added patch foo-1.1_automake_1.13.patch: Fix build with automake 1.13 by disabling -Werror ]]]
first message: i have *no* idea what you did. i would need to dig through the history to find that out. While you might still know what you did this week. will you still remember what you did in a few weeks or months? I doubt it.
changes entries are a very important communication channel to users, fellow packagers and yourself in a few months. take the time for proper communication.
I very much agree with Marcus on that one... .changes entries serve multiple purposes, one of them being documentation and aid for other packagers. The entire openSUSE Review team is not the strictest when it comes to this; frankly, I have seen many things passed through which I would likely have rejected; A simple "Fix build" just does not mean anything in a .changes entry. The packaging guidelines are surely not complete in this repsect, but they do carry a bunch of good hints of what should be done and what should not be done... One of the guidelines is to mention patch addition and removal by patch name (it really helps when you have to dig through various errors and finding our when a patch was dropped, or when it was added). In all fairness for Christian though: this is where the devel prj maintainers can surely help out more than they do: if somebody goes through hundreds of packages to fix this kind of issues, I'd argue that the devel prj maintainers can close an eye or two once in a while and support those mass-fixups by helping correct whatever they see is wrong. And only then submit the package to Factory (so the factory review team will be the 3rd pair of eye already... usually, you would have to believe that there can't be much wrong anymore at this time). Dominiqe -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org