On 07-03-2013 14:41, Dominique Leuenberger a.k.a. Dimstar wrote:
Quoting Ismail Doenmez
: Hi,
With every new architecture, one needs to update config.guess and config.sub files to recent version so configure scripts will work.
This is cumbersome because these files are huge and the patches will have to be refreshed with each release. Hence I'd like to propose a better way to do this.
First of all, we'll package gnuconfig (http://git.savannah.gnu.org/cgit/config.git/tree/) which contains official GNU config.guess/sub files.
Then add an rpm macro like
%update_config_guess_sub .
which will copy the latest config.{guess,sub} from the filesystem to the directory passed by the second parameter. This way we won't have ugly patches around.
Comments?
We already have two packages containing config.guess and config.sub: - libtool - automake
These are not always up to date :) e.g aarc64 case.
Patching the one in automake and trigger autoreconf in the packages should be sufficient to ensure there are recent enough files.. of course it's possible that automake copies and piggy-packs from other locations as well (possibly from config.git?) but me too, I think patching these files is just wrong...
My usual approach is: if the file does not live in the upstream VCS, then it's wrong to patch it :)
As for the macros: *IF* we go that route: why not have %configure do the logic and copy the right files? Instead of messing up all packages with an additional macro?
Because explicit is always better than implicit. I might want to do ../configure instead of %configure. No need to make %configure more complicated and its already is. Regards. -- SUSE LINUX Products GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg) -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org