Mailinglist Archive: opensuse-factory (475 mails)

< Previous Next >
Re: [opensuse-factory] Contrib: Packages Review: "banner"
  • From: Cristian Rodríguez <crrodriguez@xxxxxxx>
  • Date: Thu, 28 Aug 2008 17:29:49 -0400
  • Message-id: <48B718CD.3000509@xxxxxxx>
Alexey Eremenko escribió:

===============================================
What do you think of the package?



Evaluation :

a) SPEC file contains redundant definitions

b) an incorrect "BuildRoot" is used

c) it has pointless buildrequires

d) RPM_BUILD_ROOT is used during %build

e) package is built without RPM_OPT_FLAGS

f) RPM_BUILD_ROOT is deleted during %install.

g) autotools files have to be regenerated because they are too old and
errors happend during %configure

h) Group: Text tools does not exist, Productivity/Text/Utilities may be
more adecuate.

i) potentially nasty compiler warnings : implicit declaration of function...


Well. it obviosuly does not comply with policies, I fixed all the
mentioned problems. but you should try to test it better in the future ;-P







--
"A computer is like an Old Testament god, with a lot of rules and no
mercy. "

Cristian Rodríguez R.
Platform/OpenSUSE - Core Services
SUSE LINUX Products GmbH
Research & Development
http://www.opensuse.org/


< Previous Next >
Follow Ups
References