Mailinglist Archive: opensuse-factory (599 mails)

< Previous Next >
Re: [opensuse-factory] SuSEconfig clearance: SuSEconfig.automake
  • From: Robert Schiele <rschiele@xxxxxxxxxxxxxxx>
  • Date: Sat, 19 Aug 2006 01:46:48 +0200
  • Message-id: <20060818234648.GP4811@xxxxxxxxxxxxxxxxxx>
On Sat, Aug 19, 2006 at 12:06:14AM +0200, Andreas Hanke wrote:
> Hi,
>
> Robert Schiele schrieb:
> >> Do you have a patch to extend automake? ;)
> >
> > That's an easy one:
>
> This patch applies to automake-1.9.6, but not to CVS HEAD.

Sure, latest SUSE shipped version _is_ 1.9.6.

But if this is a problem for people, then the same patch for the latest and
greatest:

--- ./aclocal.in~ 2006-08-19 01:24:44.000000000 +0200
+++ ./aclocal.in 2006-08-19 01:32:03.000000000 +0200
@@ -1001,22 +1001,26 @@
}
else
{
- # Finally, adds any directory listed in the `dirlist' file.
- if (open (DIRLIST, "$system_includes[0]/dirlist"))
- {
- while (<DIRLIST>)
+ # Finally, adds any directory listed in the `dirlist' file
+ # and `dirlist.d' directories.
+ foreach my $dirlistfile (<$system_includes[0]/dirlist{,.d/*}>)
+ {
+ if (open (DIRLIST, $dirlistfile))
{
- # Ignore '#' lines.
- next if /^#/;
- # strip off newlines and end-of-line comments
- s/\s*\#.*$//;
- chomp;
- foreach my $dir (glob)
+ while (<DIRLIST>)
{
- push (@system_includes, $dir) if -d $dir;
+ # Ignore '#' lines.
+ next if /^#/;
+ # strip off newlines and end-of-line comments
+ s/\s*\#.*$//;
+ chomp;
+ foreach my $dir (glob)
+ {
+ push (@system_includes, $dir) if -d $dir;
+ }
}
+ close (DIRLIST);
}
- close (DIRLIST);
}
}
}

> Someone has to decide:

Ok, if someone has to decide, I decide for the first solution. ;-)

> - Do we want to have an extensible aclocal search path? => Then a patch
> that applies to CVS HEAD must be sent upstream. If and after it has been

If someone sends this patch there now, this is easy. Otherwise I will send in
about 10 days when I am back at home again and have the time to read all the
mailing lists. If someone else sends it, I will be reachable by mail, just
don't want to send something to mailing lists I currently don't read.

> accepted, SuSEconfig.automake becomes obsolete and can be dropped.

It can be used even when the upstream integration process has not been
completed because it is in my opinion a much better solution than the current
script, even when the patch is not yet in upstream code.

> - Don't we need an extensible aclocal search path? => Then
> SuSEconfig.automake can be dropped by including a static configuration
> file which at least temporarily references /opt/gnome/share/aclocal, or
> it has to be kept, or it has to be emulated within the %post scriptlet
> of gnome-filesystem.

Sure we need an extension mechanism for that. What do you think was the
reason for implementing this dirlist stuff in aclocal at all? Even when GNOME
didn't exist the option could be used by any package that provides something
in an unusual path.

> Sorry, I have to ask again because it's still not clear to me: Are the
> current dirlist.d and the fact that everyone can use this SUSE-only
> thingy a desired feature or are they an undesired side-effect of having
> GNOME in /opt/gnome?

In my opinion it is a desired feature. It should be made a non-SUSE-only
feature but as long as mainstream does not have it it does not really hurt
because we had it anyway up to now by the script and nobody is forced to use
it.

Robert

--
Robert Schiele Tel.: +49-621-181-2214
Dipl.-Wirtsch.informatiker mailto:rschiele@xxxxxxxxxxxxxxx

"Quidquid latine dictum sit, altum sonatur."
< Previous Next >
Follow Ups