Hello community, here is the log from the commit of package kde-user-manager for openSUSE:Factory checked in at 2016-10-22 13:07:05 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/kde-user-manager (Old) and /work/SRC/openSUSE:Factory/.kde-user-manager.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Package is "kde-user-manager" Changes: -------- --- /work/SRC/openSUSE:Factory/kde-user-manager/kde-user-manager.changes 2016-10-18 09:58:13.000000000 +0200 +++ /work/SRC/openSUSE:Factory/.kde-user-manager.new/kde-user-manager.changes 2016-10-22 13:07:06.000000000 +0200 @@ -1,0 +2,17 @@ +Tue Oct 18 16:42:24 UTC 2016 - alarrosa@suse.com + +- Add do-not-request-root-password-when-changing-avatar.diff + When the user only changes the avatar, there's no need to save all + data that wasn't modified and requires the root password. This + allows users to modify their avatar without getting a request for + the root password. + +------------------------------------------------------------------- +Tue Oct 18 15:16:03 UTC 2016 - fabian@ritter-vogt.de + +- Update to 5.8.2 + * New bugfix release + * For more details please see: + https://www.kde.org/announcements/plasma-5.8.2.php + +------------------------------------------------------------------- Old: ---- user-manager-5.8.1.tar.xz New: ---- do-not-request-root-password-when-changing-avatar.diff user-manager-5.8.2.tar.xz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ kde-user-manager.spec ++++++ --- /var/tmp/diff_new_pack.uUfmqo/_old 2016-10-22 13:07:07.000000000 +0200 +++ /var/tmp/diff_new_pack.uUfmqo/_new 2016-10-22 13:07:07.000000000 +0200 @@ -18,13 +18,15 @@ %bcond_without lang Name: kde-user-manager -Version: 5.8.1 +Version: 5.8.2 Release: 0 Summary: KDE System Settings module to manage users License: GPL-2.0+ Group: System/GUI/KDE Url: http://www.kde.org/ Source: http://download.kde.org/stable/plasma/%{version}/user-manager-%{version}.tar.xz +# PATCH-FIX-UPSTREAM do-not-request-root-password-when-changing-avatar.diff alarrosa@suse.com -- Only try to save the data the user modified +Patch0: do-not-request-root-password-when-changing-avatar.diff BuildRequires: extra-cmake-modules >= 1.3.0 BuildRequires: libpwquality-devel BuildRequires: cmake(KF5I18n) @@ -41,6 +43,7 @@ %prep %setup -q -n user-manager-%{version} +%patch0 -p1 %build %cmake_kf5 -d build -- -DCMAKE_INSTALL_LOCALEDIR=%{_kf5_localedir} ++++++ do-not-request-root-password-when-changing-avatar.diff ++++++ Index: user-manager-5.8.1/src/accountinfo.cpp =================================================================== --- user-manager-5.8.1.orig/src/accountinfo.cpp +++ user-manager-5.8.1/src/accountinfo.cpp @@ -154,20 +154,30 @@ bool AccountInfo::save() qCDebug(USER_MANAGER_LOG) << "Saving on Index: " << m_index.row(); QListAccountModel::Role failed; - if (!m_model->setData(m_index, m_info->username->text(), AccountModel::Username)) { - failed.append(AccountModel::Username); + if (m_infoToSave.contains(AccountModel::Username)) { + if (!m_model->setData(m_index, m_info->username->text(), AccountModel::Username)) { + failed.append(AccountModel::Username); + } } - if (!m_model->setData(m_index, m_info->realName->text(), AccountModel::RealName)) { - failed.append(AccountModel::RealName); + if (m_infoToSave.contains(AccountModel::RealName)) { + if (!m_model->setData(m_index, m_info->realName->text(), AccountModel::RealName)) { + failed.append(AccountModel::RealName); + } } - if (!m_model->setData(m_index, m_info->email->text(), AccountModel::Email)) { - failed.append(AccountModel::Email); + if (m_infoToSave.contains(AccountModel::Email)) { + if (!m_model->setData(m_index, m_info->email->text(), AccountModel::Email)) { + failed.append(AccountModel::Email); + } } - if (!m_model->setData(m_index, m_info->administrator->isChecked(), AccountModel::Administrator)) { - failed.append(AccountModel::Administrator); + if (m_infoToSave.contains(AccountModel::Administrator)) { + if (!m_model->setData(m_index, m_info->administrator->isChecked(), AccountModel::Administrator)) { + failed.append(AccountModel::Administrator); + } } - if (!m_model->setData(m_index, m_info->automaticLogin->isChecked(), AccountModel::AutomaticLogin)) { - failed.append(AccountModel::AutomaticLogin); + if (m_infoToSave.contains(AccountModel::AutomaticLogin)) { + if (!m_model->setData(m_index, m_info->automaticLogin->isChecked(), AccountModel::AutomaticLogin)) { + failed.append(AccountModel::AutomaticLogin); + } } if (m_infoToSave.contains(AccountModel::Password)) { if (!m_model->setData(m_index, m_infoToSave[AccountModel::Password], AccountModel::Password)) { Index: user-manager-5.8.1/src/lib/accountmodel.cpp =================================================================== --- user-manager-5.8.1.orig/src/lib/accountmodel.cpp +++ user-manager-5.8.1/src/lib/accountmodel.cpp @@ -162,8 +162,6 @@ bool AccountModel::setData(const QModelI } m_kEmailSettings.setSetting(KEMailSettings::RealName, value.toString()); - m_dbus->UncacheUser(acc->userName()).waitForFinished(); - m_dbus->CacheUser(acc->userName()); emit dataChanged(index, index); return true; case AccountModel::Username: ++++++ user-manager-5.8.1.tar.xz -> user-manager-5.8.2.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/user-manager-5.8.1/CMakeLists.txt new/user-manager-5.8.2/CMakeLists.txt --- old/user-manager-5.8.1/CMakeLists.txt 2016-10-11 14:52:26.000000000 +0200 +++ new/user-manager-5.8.2/CMakeLists.txt 2016-10-18 13:52:28.000000000 +0200 @@ -1,6 +1,6 @@ project(user-manager) cmake_minimum_required(VERSION 2.8.12) -set(PROJECT_VERSION "5.8.1") +set(PROJECT_VERSION "5.8.2") find_package(ECM 1.3.0 REQUIRED NO_MODULE) set(CMAKE_MODULE_PATH ${ECM_MODULE_PATH})