Hello community,
here is the log from the commit of package kparts for openSUSE:Factory checked in at 2016-02-24 18:56:40
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/kparts (Old)
and /work/SRC/openSUSE:Factory/.kparts.new (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "kparts"
Changes:
--------
--- /work/SRC/openSUSE:Factory/kparts/kparts.changes 2016-01-20 09:47:26.000000000 +0100
+++ /work/SRC/openSUSE:Factory/.kparts.new/kparts.changes 2016-02-24 18:56:41.000000000 +0100
@@ -1,0 +2,9 @@
+Sat Feb 6 18:05:47 UTC 2016 - hrvoje.senjan@gmail.com
+
+- Update to 5.19.0 (boo#967668)
+ * PartManager: stop tracking a widget even if it is no
+ longer top level (kde#355711)
+ * For more details please see:
+ https://www.kde.org/announcements/kde-frameworks-5.19.0.php
+
+-------------------------------------------------------------------
Old:
----
kparts-5.18.0.tar.xz
New:
----
kparts-5.19.0.tar.xz
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ kparts.spec ++++++
--- /var/tmp/diff_new_pack.feBtuM/_old 2016-02-24 18:56:42.000000000 +0100
+++ /var/tmp/diff_new_pack.feBtuM/_new 2016-02-24 18:56:42.000000000 +0100
@@ -18,9 +18,9 @@
%bcond_without lang
%define lname libKF5Parts5
-%define _tar_path 5.18
+%define _tar_path 5.19
Name: kparts
-Version: 5.18.0
+Version: 5.19.0
Release: 0
%define kf5_version %{version}
BuildRequires: cmake >= 2.8.12
++++++ kparts-5.18.0.tar.xz -> kparts-5.19.0.tar.xz ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kparts-5.18.0/CMakeLists.txt new/kparts-5.19.0/CMakeLists.txt
--- old/kparts-5.18.0/CMakeLists.txt 2016-01-02 17:46:03.000000000 +0100
+++ new/kparts-5.19.0/CMakeLists.txt 2016-02-06 14:53:54.000000000 +0100
@@ -3,7 +3,7 @@
project(KParts)
include(FeatureSummary)
-find_package(ECM 5.18.0 NO_MODULE)
+find_package(ECM 5.19.0 NO_MODULE)
set_package_properties(ECM PROPERTIES TYPE REQUIRED DESCRIPTION "Extra CMake Modules." URL "https://projects.kde.org/projects/kdesupport/extra-cmake-modules")
feature_summary(WHAT REQUIRED_PACKAGES_NOT_FOUND FATAL_ON_MISSING_REQUIRED_PACKAGES)
@@ -13,7 +13,7 @@
set(REQUIRED_QT_VERSION "5.3")
find_package(Qt5 ${REQUIRED_QT_VERSION} CONFIG REQUIRED Core Widgets Xml)
include(KDEInstallDirs)
-include(KDEFrameworkCompilerSettings)
+include(KDEFrameworkCompilerSettings NO_POLICY_SCOPE)
include(KDECMakeSettings)
@@ -21,8 +21,8 @@
include(ECMSetupVersion)
-set(KF5_VERSION "5.18.0") # handled by release scripts
-set(KF5_DEP_VERSION "5.18.0") # handled by release scripts
+set(KF5_VERSION "5.19.0") # handled by release scripts
+set(KF5_DEP_VERSION "5.19.0") # handled by release scripts
ecm_setup_version(${KF5_VERSION} VARIABLE_PREFIX KPARTS
VERSION_HEADER "${CMAKE_CURRENT_BINARY_DIR}/kparts_version.h"
PACKAGE_VERSION_FILE "${CMAKE_CURRENT_BINARY_DIR}/KF5PartsConfigVersion.cmake"
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kparts-5.18.0/po/nb/kparts5.po new/kparts-5.19.0/po/nb/kparts5.po
--- old/kparts-5.18.0/po/nb/kparts5.po 2016-01-02 17:46:03.000000000 +0100
+++ new/kparts-5.19.0/po/nb/kparts5.po 2016-02-06 14:53:54.000000000 +0100
@@ -4,7 +4,7 @@
# Bjørn Steensrud , 2002, 2003, 2004, 2005, 2007, 2008, 2009, 2010, 2011, 2012, 2013, 2014.
# Eskild Hustvedt , 2004, 2005.
# Gaute Hvoslef Kvalnes , 2004, 2005.
-# Axel Bojer , 2005, 2006.
+# Axel Bojer , 2005, 2006.
# Nils Kristian Tomren , 2005, 2007.
# Øyvind A. Holm , 2009.
msgid ""
@@ -31,7 +31,8 @@
msgctxt "EMAIL OF TRANSLATORS"
msgid "Your emails"
-msgstr "knut.yrvin@gmail.com,axel@bojer.no,bjornst@skogkatt.homelinux.org"
+msgstr ""
+"knut.yrvin@gmail.com,fri_programvare@bojer.no,bjornst@skogkatt.homelinux.org"
#: browserextension.cpp:241
#, kde-format
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kparts-5.18.0/src/browserextension.cpp new/kparts-5.19.0/src/browserextension.cpp
--- old/kparts-5.18.0/src/browserextension.cpp 2016-01-02 17:46:03.000000000 +0100
+++ new/kparts-5.19.0/src/browserextension.cpp 2016-02-06 14:53:54.000000000 +0100
@@ -136,14 +136,14 @@
d->m_actionStatus.setBit(i, metaobj->indexOfMethod(slotSig.constData()) != -1);
}
- connect(d->m_part, SIGNAL(completed()),
- this, SLOT(slotCompleted()));
- connect(this, SIGNAL(openUrlRequest(QUrl,KParts::OpenUrlArguments,KParts::BrowserArguments)),
- this, SLOT(slotOpenUrlRequest(QUrl,KParts::OpenUrlArguments,KParts::BrowserArguments)));
- connect(this, SIGNAL(enableAction(const char*,bool)),
- this, SLOT(slotEnableAction(const char*,bool)));
- connect(this, SIGNAL(setActionText(const char*,QString)),
- this, SLOT(slotSetActionText(const char*,QString)));
+ connect(d->m_part, static_cast(&KParts::ReadOnlyPart::completed),
+ this, &BrowserExtension::slotCompleted);
+ connect(this, &BrowserExtension::openUrlRequest,
+ this, &BrowserExtension::slotOpenUrlRequest);
+ connect(this, &BrowserExtension::enableAction,
+ this, &BrowserExtension::slotEnableAction);
+ connect(this, &BrowserExtension::setActionText,
+ this, &BrowserExtension::slotSetActionText);
}
BrowserExtension::~BrowserExtension()
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kparts-5.18.0/src/browseropenorsavequestion.cpp new/kparts-5.19.0/src/browseropenorsavequestion.cpp
--- old/kparts-5.18.0/src/browseropenorsavequestion.cpp 2016-01-02 17:46:03.000000000 +0100
+++ new/kparts-5.19.0/src/browseropenorsavequestion.cpp 2016-02-06 14:53:54.000000000 +0100
@@ -133,10 +133,10 @@
QPushButton *cancelButton = buttonBox->addButton(QDialogButtonBox::Cancel);
cancelButton->setObjectName(QStringLiteral("cancelButton"));
- connect(saveButton, SIGNAL(clicked()), this, SLOT(slotYesClicked()));
- connect(openDefaultButton, SIGNAL(clicked()), this, SLOT(slotOpenDefaultClicked()));
- connect(openWithButton, SIGNAL(clicked()), this, SLOT(slotOpenWithClicked()));
- connect(buttonBox, SIGNAL(rejected()), this, SLOT(reject()));
+ connect(saveButton, &QPushButton::clicked, this, &BrowserOpenOrSaveQuestionPrivate::slotYesClicked);
+ connect(openDefaultButton, &QPushButton::clicked, this, &BrowserOpenOrSaveQuestionPrivate::slotOpenDefaultClicked);
+ connect(openWithButton, &QPushButton::clicked, this, &BrowserOpenOrSaveQuestionPrivate::slotOpenWithClicked);
+ connect(buttonBox, &QDialogButtonBox::rejected, this, &BrowserOpenOrSaveQuestionPrivate::reject);
mainLayout->addWidget(buttonBox);
}
@@ -269,7 +269,7 @@
KGuiItem openWithItem(i18nc("@label:button", "&Open with"), QStringLiteral("document-open"));
KGuiItem::assign(d->openWithButton, openWithItem);
d->openWithButton->setMenu(menu);
- QObject::connect(menu, SIGNAL(triggered(QAction*)), d, SLOT(slotAppSelected(QAction*)));
+ QObject::connect(menu, &QMenu::triggered, d, &BrowserOpenOrSaveQuestionPrivate::slotAppSelected);
for (KService::List::const_iterator it = apps.begin(); it != apps.end(); ++it) {
QAction *act = createAppAction(*it, d);
menu->addAction(act);
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kparts-5.18.0/src/browseropenorsavequestion.h new/kparts-5.19.0/src/browseropenorsavequestion.h
--- old/kparts-5.18.0/src/browseropenorsavequestion.h 2016-01-02 17:46:03.000000000 +0100
+++ new/kparts-5.19.0/src/browseropenorsavequestion.h 2016-02-06 14:53:54.000000000 +0100
@@ -106,6 +106,7 @@
private:
BrowserOpenOrSaveQuestionPrivate *const d;
+ Q_DISABLE_COPY(BrowserOpenOrSaveQuestion)
};
}
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kparts-5.18.0/src/browserrun.cpp new/kparts-5.19.0/src/browserrun.cpp
--- old/kparts-5.18.0/src/browserrun.cpp 2016-01-02 17:46:03.000000000 +0100
+++ new/kparts-5.19.0/src/browserrun.cpp 2016-02-06 14:53:54.000000000 +0100
@@ -170,10 +170,10 @@
job->addMetaData(metaData);
KJobWidgets::setWindow(job, d->m_window);
- connect(job, SIGNAL(result(KJob*)),
- this, SLOT(slotBrowserScanFinished(KJob*)));
- connect(job, SIGNAL(mimetype(KIO::Job*,QString)),
- this, SLOT(slotBrowserMimetype(KIO::Job*,QString)));
+ connect(job, &KIO::TransferJob::result,
+ this, &BrowserRun::slotBrowserScanFinished);
+ connect(job, static_cast(&KIO::TransferJob::mimetype),
+ this, &BrowserRun::slotBrowserMimetype);
setJob(job);
}
@@ -229,7 +229,7 @@
const QString modificationTime = job->queryMetaData(QStringLiteral("content-disposition-modification-date"));
if (!modificationTime.isEmpty()) {
- d->m_args.metaData().insert(QLatin1String("content-disposition-modification-date"), modificationTime);
+ d->m_args.metaData().insert(QStringLiteral("content-disposition-modification-date"), modificationTime);
}
QMapIterator it(job->metaData());
@@ -269,7 +269,7 @@
if (mimeType != QLatin1String("inode/directory") && // dirs can't be saved
!KRun::url().isLocalFile()) {
if (isTextExecutable(mimeType)) {
- mimeType = QLatin1String("text/plain"); // view, don't execute
+ mimeType = QStringLiteral("text/plain"); // view, don't execute
}
// ... -> ask whether to save
BrowserOpenOrSaveQuestion question(d->m_window, KRun::url(), mimeType);
@@ -306,8 +306,8 @@
QUrl destURL = QUrl::fromLocalFile(tempFile.fileName());
KIO::Job *job = KIO::file_copy(KRun::url(), destURL, 0600, KIO::Overwrite);
KJobWidgets::setWindow(job, d->m_window);
- connect(job, SIGNAL(result(KJob*)),
- this, SLOT(slotCopyToTempFileResult(KJob*)));
+ connect(job, &KIO::Job::result,
+ this, &BrowserRun::slotCopyToTempFileResult);
return Delayed; // We'll continue after the job has finished
}
if (selectedService && question.selectedService()) {
@@ -439,7 +439,7 @@
dlg->selectFile(name);
if (dlg->exec()) {
- QUrl destURL(dlg->selectedUrls().first());
+ QUrl destURL(dlg->selectedUrls().at(0));
if (destURL.isValid()) {
saveUrlUsingKIO(url, destURL, window, args.metaData());
}
@@ -452,7 +452,7 @@
{
KIO::FileCopyJob *job = KIO::file_copy(srcUrl, destUrl, -1, KIO::Overwrite);
- const QString modificationTime = metaData[QLatin1String("content-disposition-modification-date")];
+ const QString modificationTime = metaData[QStringLiteral("content-disposition-modification-date")];
if (!modificationTime.isEmpty()) {
job->setModificationTime(QDateTime::fromString(modificationTime, Qt::RFC2822Date));
}
@@ -501,7 +501,7 @@
* error = int kio error code, errText = QString error text from kio
* The sub-url is the URL that we were trying to open.
*/
- QUrl newURL(QString::fromLatin1("error:/?error=%1&errText=%2")
+ QUrl newURL(QStringLiteral("error:/?error=%1&errText=%2")
.arg(error)
.arg(QString::fromUtf8(QUrl::toPercentEncoding(errorText))));
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kparts-5.18.0/src/browserrun_p.h new/kparts-5.19.0/src/browserrun_p.h
--- old/kparts-5.18.0/src/browserrun_p.h 2016-01-02 17:46:03.000000000 +0100
+++ new/kparts-5.19.0/src/browserrun_p.h 2016-02-06 14:53:54.000000000 +0100
@@ -48,7 +48,7 @@
// qDebug() << "download started: srcUrl=" << job->srcUrl()
// << "destUrl=" << job->destUrl()
// << "referrer=" << m_metaData.value("referrer");
- connect(job, SIGNAL(result(KJob *)), this, SLOT(slotDownloadFinished(KJob *)));
+ connect(job, &KIO::FileCopyJob::result, this, &DownloadJobWatcher::slotDownloadFinished);
}
private Q_SLOTS:
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kparts-5.18.0/src/mainwindow.cpp new/kparts-5.19.0/src/mainwindow.cpp
--- old/kparts-5.18.0/src/mainwindow.cpp 2016-01-02 17:46:03.000000000 +0100
+++ new/kparts-5.19.0/src/mainwindow.cpp 2016-02-06 14:53:54.000000000 +0100
@@ -96,10 +96,10 @@
factory->removeClient(d->m_activePart);
- disconnect(d->m_activePart, SIGNAL(setWindowCaption(QString)),
- this, SLOT(setCaption(QString)));
- disconnect(d->m_activePart, SIGNAL(setStatusBarText(QString)),
- this, SLOT(slotSetStatusBarText(QString)));
+ disconnect(d->m_activePart.data(), &Part::setWindowCaption,
+ this, static_cast(&MainWindow::setCaption));
+ disconnect(d->m_activePart.data(), &Part::setStatusBarText,
+ this, &MainWindow::slotSetStatusBarText);
}
if (!d->m_bShellGUIActivated) {
@@ -110,10 +110,10 @@
if (part) {
// do this before sending the activate event
- connect(part, SIGNAL(setWindowCaption(QString)),
- this, SLOT(setCaption(QString)));
- connect(part, SIGNAL(setStatusBarText(QString)),
- this, SLOT(slotSetStatusBarText(QString)));
+ connect(part, &Part::setWindowCaption,
+ this, static_cast(&MainWindow::setCaption));
+ connect(part, &Part::setStatusBarText,
+ this, &MainWindow::slotSetStatusBarText);
factory->addClient(part);
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kparts-5.18.0/src/part.cpp new/kparts-5.19.0/src/part.cpp
--- old/kparts-5.18.0/src/part.cpp 2016-01-02 17:46:03.000000000 +0100
+++ new/kparts-5.19.0/src/part.cpp 2016-02-06 14:53:54.000000000 +0100
@@ -52,8 +52,8 @@
if (d->m_widget) {
// We need to disconnect first, to avoid calling it !
- disconnect(d->m_widget, SIGNAL(destroyed()),
- this, SLOT(slotWidgetDestroyed()));
+ disconnect(d->m_widget.data(), &QWidget::destroyed,
+ this, &Part::slotWidgetDestroyed);
}
if (d->m_manager) {
@@ -135,8 +135,8 @@
{
Q_D(Part);
d->m_widget = widget;
- connect(d->m_widget, SIGNAL(destroyed()),
- this, SLOT(slotWidgetDestroyed()), Qt::UniqueConnection);
+ connect(d->m_widget.data(), &QWidget::destroyed,
+ this, &Part::slotWidgetDestroyed, Qt::UniqueConnection);
}
void Part::setSelectable(bool selectable)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kparts-5.18.0/src/partmanager.cpp new/kparts-5.19.0/src/partmanager.cpp
--- old/kparts-5.18.0/src/partmanager.cpp 2016-01-02 17:46:03.000000000 +0100
+++ new/kparts-5.19.0/src/partmanager.cpp 2016-02-06 14:53:54.000000000 +0100
@@ -132,8 +132,8 @@
PartManager::~PartManager()
{
foreach (const QWidget *w, d->m_managedTopLevelWidgets) {
- disconnect(w, SIGNAL(destroyed()),
- this, SLOT(slotManagedTopLevelWidgetDestroyed()));
+ disconnect(w, &QWidget::destroyed,
+ this, &PartManager::slotManagedTopLevelWidgetDestroyed);
}
foreach (Part *it, d->m_parts) {
@@ -454,8 +454,8 @@
PartActivateEvent ev(false, oldActivePart, oldActiveWidget);
QApplication::sendEvent(oldActivePart, &ev);
if (oldActiveWidget) {
- disconnect(oldActiveWidget, SIGNAL(destroyed()),
- this, SLOT(slotWidgetDestroyed()));
+ disconnect(oldActiveWidget, &QWidget::destroyed,
+ this, &PartManager::slotWidgetDestroyed);
QApplication::sendEvent(oldActiveWidget, &ev);
}
@@ -471,8 +471,8 @@
PartActivateEvent ev(true, d->m_activePart, d->m_activeWidget);
QApplication::sendEvent(d->m_activePart, &ev);
if (d->m_activeWidget) {
- connect(d->m_activeWidget, SIGNAL(destroyed()),
- this, SLOT(slotWidgetDestroyed()));
+ connect(d->m_activeWidget, &QWidget::destroyed,
+ this, &PartManager::slotWidgetDestroyed);
QApplication::sendEvent(d->m_activeWidget, &ev);
}
}
@@ -565,16 +565,12 @@
}
d->m_managedTopLevelWidgets.append(topLevel);
- connect(topLevel, SIGNAL(destroyed()),
- this, SLOT(slotManagedTopLevelWidgetDestroyed()));
+ connect(topLevel, &QWidget::destroyed,
+ this, &PartManager::slotManagedTopLevelWidgetDestroyed);
}
void PartManager::removeManagedTopLevelWidget(const QWidget *topLevel)
{
- if (!topLevel->isTopLevel()) {
- return;
- }
-
d->m_managedTopLevelWidgets.removeAll(topLevel);
}
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kparts-5.18.0/src/plugin.cpp new/kparts-5.19.0/src/plugin.cpp
--- old/kparts-5.18.0/src/plugin.cpp 2016-01-02 17:46:03.000000000 +0100
+++ new/kparts-5.19.0/src/plugin.cpp 2016-02-06 14:53:54.000000000 +0100
@@ -93,7 +93,7 @@
const QStringList dirs = QStandardPaths::locateAll(QStandardPaths::GenericDataLocation, componentName + QStringLiteral("/kpartplugins"), QStandardPaths::LocateDirectory);
Q_FOREACH (const QString &dir, dirs) {
- Q_FOREACH (const QString &file, QDir(dir).entryList(QStringList() << QLatin1String("*.rc"))) {
+ Q_FOREACH (const QString &file, QDir(dir).entryList(QStringList("*.rc"))) {
const QFileInfo fInfo(dir + QLatin1Char('/') + file);
QMap::Iterator mapIt = sortedPlugins.find(fInfo.fileName());
if (mapIt == sortedPlugins.end()) {
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kparts-5.18.0/src/scriptableextension.cpp new/kparts-5.19.0/src/scriptableextension.cpp
--- old/kparts-5.18.0/src/scriptableextension.cpp 2016-01-02 17:46:03.000000000 +0100
+++ new/kparts-5.19.0/src/scriptableextension.cpp 2016-02-06 14:53:54.000000000 +0100
@@ -84,7 +84,7 @@
static QVariant unimplemented()
{
- ScriptableExtension::Exception except(QString::fromLatin1("[unimplemented]"));
+ ScriptableExtension::Exception except(QStringLiteral("[unimplemented]"));
return QVariant::fromValue(except);
}
@@ -230,9 +230,9 @@
ScriptableExtension(p), wrapee(old)
{
connect(wrapee,
- SIGNAL(partEvent(ulong,QString,KParts::LiveConnectExtension::ArgList)),
+ &LiveConnectExtension::partEvent,
this,
- SLOT(liveConnectEvent(ulong,QString,KParts::LiveConnectExtension::ArgList)));
+ &ScriptableLiveConnectExtension::liveConnectEvent);
}
QVariant ScriptableLiveConnectExtension::rootObject()
@@ -256,6 +256,7 @@
{
QStringList qargs;
// Convert args to strings for LC use.
+ qargs.reserve(a.size());
for (int i = 0; i < a.size(); ++i) {
bool ok;
qargs.append(toLC(a[i], &ok));
@@ -356,15 +357,15 @@
// Convert null and undefined to appropriate strings
// ### this matches old KHTML behavior, but is this sensible?
if (in.canConvertScriptableExtension::Null()) {
- return QString::fromLatin1("null");
+ return QStringLiteral("null");
}
if (in.canConvertScriptableExtension::Undefined()) {
- return QString::fromLatin1("undefined");
+ return QStringLiteral("undefined");
}
if (in.type() == QVariant::Bool) {
- return in.toBool() ? QString::fromLatin1("true") : QString::fromLatin1("false");
+ return in.toBool() ? QStringLiteral("true") : QStringLiteral("false");
}
// Just stringify everything else, makes sense for nums as well.