Hello community, here is the log from the commit of package yast2-storage for openSUSE:Factory checked in at 2015-07-22 09:19:25 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/yast2-storage (Old) and /work/SRC/openSUSE:Factory/.yast2-storage.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Package is "yast2-storage" Changes: -------- --- /work/SRC/openSUSE:Factory/yast2-storage/yast2-storage.changes 2015-07-05 17:51:38.000000000 +0200 +++ /work/SRC/openSUSE:Factory/.yast2-storage.new/yast2-storage.changes 2015-07-22 09:19:27.000000000 +0200 @@ -1,0 +2,26 @@ +Wed Jul 17 13:31:34 CEST 2015 - dvaleev@suse.com + +- Allow /boot on RAID1 (bsc#938170) +- 3.1.63 + +------------------------------------------------------------------- +Thu Jul 16 14:33:10 CEST 2015 - aschnell@suse.de + +- do not try to load snapper extension since it does not exist + anymore (see bsc#937243) +- 3.1.62 + +------------------------------------------------------------------- +Tue Jul 14 15:27:09 CEST 2015 - schubi@suse.de + +- Loading the correct multipath module (dm-multipath) + (bnc#937942) +- 3.1.61 + +------------------------------------------------------------------- +Tue Jun 30 11:49:34 CEST 2015 - aschnell@suse.de + +- disallow using unpartitioned DASDs for LVM (fate#317934) +- 3.1.60 + +------------------------------------------------------------------- Old: ---- yast2-storage-3.1.59.tar.bz2 New: ---- yast2-storage-3.1.63.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ yast2-storage.spec ++++++ --- /var/tmp/diff_new_pack.hIf7Ca/_old 2015-07-22 09:19:28.000000000 +0200 +++ /var/tmp/diff_new_pack.hIf7Ca/_new 2015-07-22 09:19:28.000000000 +0200 @@ -17,7 +17,7 @@ Name: yast2-storage -Version: 3.1.59 +Version: 3.1.63 Release: 0 BuildRoot: %{_tmppath}/%{name}-%{version}-build ++++++ yast2-storage-3.1.59.tar.bz2 -> yast2-storage-3.1.63.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-storage-3.1.59/package/yast2-storage.changes new/yast2-storage-3.1.63/package/yast2-storage.changes --- old/yast2-storage-3.1.59/package/yast2-storage.changes 2015-06-26 12:43:28.000000000 +0200 +++ new/yast2-storage-3.1.63/package/yast2-storage.changes 2015-07-20 13:13:38.000000000 +0200 @@ -1,4 +1,30 @@ ------------------------------------------------------------------- +Wed Jul 17 13:31:34 CEST 2015 - dvaleev@suse.com + +- Allow /boot on RAID1 (bsc#938170) +- 3.1.63 + +------------------------------------------------------------------- +Thu Jul 16 14:33:10 CEST 2015 - aschnell@suse.de + +- do not try to load snapper extension since it does not exist + anymore (see bsc#937243) +- 3.1.62 + +------------------------------------------------------------------- +Tue Jul 14 15:27:09 CEST 2015 - schubi@suse.de + +- Loading the correct multipath module (dm-multipath) + (bnc#937942) +- 3.1.61 + +------------------------------------------------------------------- +Tue Jun 30 11:49:34 CEST 2015 - aschnell@suse.de + +- disallow using unpartitioned DASDs for LVM (fate#317934) +- 3.1.60 + +------------------------------------------------------------------- Fri Jun 26 10:18:28 CEST 2015 - aschnell@suse.de - added Storage::SetUserdata() (for bsc#935858) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-storage-3.1.59/package/yast2-storage.spec new/yast2-storage-3.1.63/package/yast2-storage.spec --- old/yast2-storage-3.1.59/package/yast2-storage.spec 2015-06-26 12:43:28.000000000 +0200 +++ new/yast2-storage-3.1.63/package/yast2-storage.spec 2015-07-20 13:13:38.000000000 +0200 @@ -17,7 +17,7 @@ Name: yast2-storage -Version: 3.1.59 +Version: 3.1.63 Release: 0 BuildRoot: %{_tmppath}/%{name}-%{version}-build diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-storage-3.1.59/src/include/partitioning/custom_part_lib.rb new/yast2-storage-3.1.63/src/include/partitioning/custom_part_lib.rb --- old/yast2-storage-3.1.59/src/include/partitioning/custom_part_lib.rb 2015-06-26 12:43:28.000000000 +0200 +++ new/yast2-storage-3.1.63/src/include/partitioning/custom_part_lib.rb 2015-07-20 13:13:38.000000000 +0200 @@ -73,9 +73,9 @@ # @param [String] mount mount point # @return [Boolean] # - def check_raid_mount_points(mount) + def check_raid_mount_points(mount, raid_level) not_allowed_raid_mount_points = [] - if Arch.ppc || Arch.s390 + if (Arch.ppc && raid_level != "raid1") || Arch.s390 not_allowed_raid_mount_points = Builtins.add( not_allowed_raid_mount_points, Partitions.BootMount @@ -360,7 +360,7 @@ Ops.set(ret, "field", :mount_point) end if Ops.get_symbol(new, "type", :primary) == :sw_raid - if !check_raid_mount_points(Ops.get_string(new, "mount", "")) + if !check_raid_mount_points(Ops.get_string(new, "mount", ""), Ops.get_string(new, "raid_type", "")) Ops.set(ret, "ok", false) Ops.set(ret, "field", :mount_point) end diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-storage-3.1.59/src/include/partitioning/lvm_pv_lib.rb new/yast2-storage-3.1.63/src/include/partitioning/lvm_pv_lib.rb --- old/yast2-storage-3.1.59/src/include/partitioning/lvm_pv_lib.rb 2015-06-26 12:43:28.000000000 +0200 +++ new/yast2-storage-3.1.63/src/include/partitioning/lvm_pv_lib.rb 2015-07-20 13:13:38.000000000 +0200 @@ -128,9 +128,11 @@ ) end if Builtins.size(Ops.get_list(devmap, "partitions", [])) == 0 && - Storage.IsPartType(Ops.get_symbol(devmap, "type", :CT_UNKNOWN)) && - (!Storage.IsUsedBy(devmap) || - Ops.get_symbol(devmap, "used_by_type", :UB_NONE) == :UB_LVM) + Storage.IsPartType(Ops.get_symbol(devmap, "type", :CT_UNKNOWN)) && + # unpartitioned DASDs cannot be used for LVM (fate #317934) + !String.StartsWith(dev, "/dev/dasd") && + (!Storage.IsUsedBy(devmap) || + Ops.get_symbol(devmap, "used_by_type", :UB_NONE) == :UB_LVM) p = { "device" => dev, "maindev" => dev, diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-storage-3.1.59/src/modules/StorageControllers.rb new/yast2-storage-3.1.63/src/modules/StorageControllers.rb --- old/yast2-storage-3.1.59/src/modules/StorageControllers.rb 2015-06-26 12:43:28.000000000 +0200 +++ new/yast2-storage-3.1.63/src/modules/StorageControllers.rb 2015-07-20 13:13:38.000000000 +0200 @@ -405,7 +405,7 @@ SCR.Execute(path(".target.modprobe"), "raid5", "") SCR.Execute(path(".target.modprobe"), "raid6", "") SCR.Execute(path(".target.modprobe"), "raid10", "") - SCR.Execute(path(".target.modprobe"), "multipath", "") + SCR.Execute(path(".target.modprobe"), "dm-multipath", "") StartHotplugStorage() diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-storage-3.1.59/src/modules/StorageSnapper.rb new/yast2-storage-3.1.63/src/modules/StorageSnapper.rb --- old/yast2-storage-3.1.59/src/modules/StorageSnapper.rb 2015-06-26 12:43:28.000000000 +0200 +++ new/yast2-storage-3.1.63/src/modules/StorageSnapper.rb 2015-07-20 13:13:38.000000000 +0200 @@ -37,7 +37,6 @@ Yast.import "String" Yast.import "Installation" - Yast.import "InstExtensionImage" Yast.import "Storage" end @@ -76,11 +75,6 @@ log.info("configuring snapper for root fs - step 1") - if ENV["YAST2_STORAGE_SNAPPER_EXTEND"] != "no" - # TRANSLATORS: message in progress bar - InstExtensionImage.LoadExtension("snapper", _("Retrieving %s extension...") % "snapper") - end - part = Storage.GetEntryForMountpoint("/") if bash_log_output("/usr/lib/snapper/installation-helper --step 1 " << @@ -118,11 +112,6 @@ log.error("configuring snapper for root fs failed") end - if ENV["YAST2_STORAGE_SNAPPER_EXTEND"] != "no" - # TRANSLATORS: message in progress bar - InstExtensionImage.UnLoadExtension("snapper", _("Releasing %s extension...") % "snapper") - end - end diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-storage-3.1.59/test/Makefile.am new/yast2-storage-3.1.63/test/Makefile.am --- old/yast2-storage-3.1.59/test/Makefile.am 2015-06-26 12:43:28.000000000 +0200 +++ new/yast2-storage-3.1.63/test/Makefile.am 2015-07-20 13:13:38.000000000 +0200 @@ -5,7 +5,8 @@ TESTS = \ format_target_map_test.rb \ storage_snapper_configure_snapper_test.rb \ - storage_get_disk_partition.rb + storage_get_disk_partition.rb \ + storage_boot_on_raid1.rb TEST_EXTENSIONS = .rb RB_LOG_COMPILER = rspec diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-storage-3.1.59/test/storage_boot_on_raid1.rb new/yast2-storage-3.1.63/test/storage_boot_on_raid1.rb --- old/yast2-storage-3.1.59/test/storage_boot_on_raid1.rb 1970-01-01 01:00:00.000000000 +0100 +++ new/yast2-storage-3.1.63/test/storage_boot_on_raid1.rb 2015-07-20 13:13:38.000000000 +0200 @@ -0,0 +1,47 @@ +#!/usr/bin/env rspec + +$LOAD_PATH.unshift File.expand_path('../../src', __FILE__) +ENV["Y2DIR"] = File.expand_path("../../src", __FILE__) + +require "yast" + +require "include/partitioning/custom_part_lib" + +class CustomPartLib < Yast::Client + include Singleton + def initialize + Yast.include self, "partitioning/custom_part_lib.rb" + end +end + +Yast.import "Arch" +Yast.import "Partitions" + +describe "CustomPartLib#CheckOkMount" do + + + it "/boot is only possible with RAID1 on PowerPC" do + + allow(Yast::Arch).to receive(:architecture).and_return("ppc") + allow(Yast::Partitions).to receive(:EfiBoot).and_return(false) + + expect(CustomPartLib.instance.check_raid_mount_points("/boot", "raid1")).to eq true + end + + it "We cannot put /boot/zipl on any RAID" do + + allow(Yast::Arch).to receive(:architecture).and_return("s390_64") + allow(Yast::Partitions).to receive(:EfiBoot).and_return(false) + + expect(CustomPartLib.instance.check_raid_mount_points("/boot/zipl", "raid1")).to eq false + end + + it "x86 can boot with /boot on RAID1 " do + + allow(Yast::Arch).to receive(:architecture).and_return("x86_64") + allow(Yast::Partitions).to receive(:EfiBoot).and_return(false) + + expect(CustomPartLib.instance.check_raid_mount_points("/boot", "raid1")).to eq true + end + +end