Hello community, here is the log from the commit of package perl-Bootloader for openSUSE:Factory checked in at 2014-04-13 13:13:13 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/perl-Bootloader (Old) and /work/SRC/openSUSE:Factory/.perl-Bootloader.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Package is "perl-Bootloader" Changes: -------- --- /work/SRC/openSUSE:Factory/perl-Bootloader/perl-Bootloader.changes 2014-04-05 14:43:09.000000000 +0200 +++ /work/SRC/openSUSE:Factory/.perl-Bootloader.new/perl-Bootloader.changes 2014-04-13 13:13:17.000000000 +0200 @@ -1,0 +2,10 @@ +Wed Apr 9 15:06:33 CEST 2014 - snwint@suse.de + +- drop old log /var/log/YaST2/perl-BL-standalone-log +- remove /var/log/YaST2/y2log_bootloader +- add MaxDepth parameter to logging function +- clean up logging in some functions +- use logrotate file (bnc #822774) +- 0.811 + +------------------------------------------------------------------- Old: ---- perl-Bootloader-0.810.tar.xz New: ---- perl-Bootloader-0.811.tar.xz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ perl-Bootloader.spec ++++++ --- /var/tmp/diff_new_pack.vtrn1Q/_old 2014-04-13 13:13:19.000000000 +0200 +++ /var/tmp/diff_new_pack.vtrn1Q/_new 2014-04-13 13:13:19.000000000 +0200 @@ -17,7 +17,7 @@ Name: perl-Bootloader -Version: 0.810 +Version: 0.811 Release: 0 Requires: coreutils Requires: e2fsprogs @@ -107,6 +107,7 @@ /sbin/update-bootloader /usr/lib/bootloader /boot/boot.readme +/etc/logrotate.d/pbl %dir %attr(0700,root,root) /var/log/YaST2 %ghost %attr(0600,root,root) /var/log/pbl.log ++++++ perl-Bootloader-0.810.tar.xz -> perl-Bootloader-0.811.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/perl-Bootloader-0.810/Makefile new/perl-Bootloader-0.811/Makefile --- old/perl-Bootloader-0.810/Makefile 2014-04-03 14:16:53.000000000 +0200 +++ new/perl-Bootloader-0.811/Makefile 2014-04-10 11:12:33.000000000 +0200 @@ -49,6 +49,7 @@ @install -d -m 755 $(DESTDIR)/boot @install -m 644 boot.readme $(DESTDIR)/boot/ @install -d -m 755 $(DESTDIR)/usr/share/man/man8/ + @install -D -m 644 pbl.logrotate $(DESTDIR)/etc/logrotate.d/pbl @pod2man update-bootloader >$(DESTDIR)/usr/share/man/man8/update-bootloader.8 @chmod 644 $(DESTDIR)/usr/share/man/man8/update-bootloader.8 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/perl-Bootloader-0.810/pbl.logrotate new/perl-Bootloader-0.811/pbl.logrotate --- old/perl-Bootloader-0.810/pbl.logrotate 1970-01-01 01:00:00.000000000 +0100 +++ new/perl-Bootloader-0.811/pbl.logrotate 2014-04-10 11:12:33.000000000 +0200 @@ -0,0 +1,11 @@ +/var/log/pbl.log { + compress + dateext + missingok + notifempty + create 600 root root + extension .log + maxage 365 + rotate 10 + size +4096k +} diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/perl-Bootloader-0.810/perl-Bootloader.changes new/perl-Bootloader-0.811/perl-Bootloader.changes --- old/perl-Bootloader-0.810/perl-Bootloader.changes 2014-04-03 14:16:53.000000000 +0200 +++ new/perl-Bootloader-0.811/perl-Bootloader.changes 2014-04-10 11:12:33.000000000 +0200 @@ -1,4 +1,14 @@ ------------------------------------------------------------------- +Wed Apr 9 15:06:33 CEST 2014 - snwint@suse.de + +- drop old log /var/log/YaST2/perl-BL-standalone-log +- remove /var/log/YaST2/y2log_bootloader +- add MaxDepth parameter to logging function +- clean up logging in some functions +- use logrotate file (bnc #822774) +- 0.811 + +------------------------------------------------------------------- Thu Apr 3 14:16:07 CEST 2014 - snwint@suse.de - fix ppc install (bnc #871691) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/perl-Bootloader-0.810/perl-Bootloader.spec.in new/perl-Bootloader-0.811/perl-Bootloader.spec.in --- old/perl-Bootloader-0.810/perl-Bootloader.spec.in 2014-04-03 14:16:53.000000000 +0200 +++ new/perl-Bootloader-0.811/perl-Bootloader.spec.in 2014-04-10 11:12:33.000000000 +0200 @@ -101,6 +101,7 @@ /sbin/update-bootloader /usr/lib/bootloader /boot/boot.readme +/etc/logrotate.d/pbl %dir %attr(0700,root,root) /var/log/YaST2 %ghost %attr(0600,root,root) /var/log/pbl.log diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/perl-Bootloader-0.810/src/Core/ELILO.pm new/perl-Bootloader-0.811/src/Core/ELILO.pm --- old/perl-Bootloader-0.810/src/Core/ELILO.pm 2014-04-03 14:16:53.000000000 +0200 +++ new/perl-Bootloader-0.811/src/Core/ELILO.pm 2014-04-10 11:12:33.000000000 +0200 @@ -675,8 +675,7 @@ system ("mkdir -p $efi") unless -d "$efi"; return 0 == $self->RunCommand ( - Bootloader::Path::Elilo_elilo() . " -v", - Bootloader::Path::BootCommandLogname() + Bootloader::Path::Elilo_elilo() . " -v" ); } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/perl-Bootloader-0.810/src/Core/GRUB.pm new/perl-Bootloader-0.811/src/Core/GRUB.pm --- old/perl-Bootloader-0.810/src/Core/GRUB.pm 2014-04-03 14:16:53.000000000 +0200 +++ new/perl-Bootloader-0.811/src/Core/GRUB.pm 2014-04-10 11:12:33.000000000 +0200 @@ -1985,25 +1985,14 @@ # FIXME: generic_mbr # write generic_mbr in case - my $log = Bootloader::Path::BootCommandLogname(); my $grub = Bootloader::Path::Grub_grub(); my $grubconf = Bootloader::Path::Grub_grubconf(); my $devicemap = Bootloader::Path::Grub_devicemap(); my $ret = $self->RunCommand ( - "cat $grubconf | $grub --device-map=$devicemap --batch", - $log + "cat $grubconf | $grub --device-map=$devicemap --batch" ); - if ($ret == 0) - { - open (LOG, $log) || return $ret; - while (my $line = <LOG>) - { - if ($line =~ /Error [0-9]*:/) - { - return undef; - } - } - close (LOG); + if ($self->{last_command}{out} =~ /Error [0-9]*:/) { + return undef; } return $ret == 0; } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/perl-Bootloader-0.810/src/Core/GRUB2.pm new/perl-Bootloader-0.811/src/Core/GRUB2.pm --- old/perl-Bootloader-0.810/src/Core/GRUB2.pm 2014-04-03 14:16:53.000000000 +0200 +++ new/perl-Bootloader-0.811/src/Core/GRUB2.pm 2014-04-10 11:12:33.000000000 +0200 @@ -1282,14 +1282,12 @@ if (defined $default and $default ne "") { $self->RunCommand ( - "/usr/sbin/grub2-set-default '$default'", - Bootloader::Path::BootCommandLogname() + "/usr/sbin/grub2-set-default '$default'" ); } return 0 == $self->RunCommand ( - "/usr/sbin/grub2-mkconfig -o /boot/grub2/grub.cfg", - Bootloader::Path::BootCommandLogname() + "/usr/sbin/grub2-mkconfig -o /boot/grub2/grub.cfg" ); } @@ -1357,18 +1355,14 @@ } } - my $ret = $self->RunCommand ( - "$cmd $opt", - Bootloader::Path::BootCommandLogname() - ); + my $ret = $self->RunCommand ("$cmd $opt"); return 0 if (0 != $ret); } } else { my $ret = $self->RunCommand ( - "/usr/sbin/grub2-install --target=$self->{'target'}", - Bootloader::Path::BootCommandLogname() + "/usr/sbin/grub2-install --target=$self->{'target'}" ); return 0 if $ret; @@ -1378,14 +1372,12 @@ if (defined $default and $default ne "") { $self->RunCommand ( - "/usr/sbin/grub2-set-default '$default'", - Bootloader::Path::BootCommandLogname() + "/usr/sbin/grub2-set-default '$default'" ); } return 0 == $self->RunCommand ( - "/usr/sbin/grub2-mkconfig -o /boot/grub2/grub.cfg", - Bootloader::Path::BootCommandLogname() + "/usr/sbin/grub2-mkconfig -o /boot/grub2/grub.cfg" ); } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/perl-Bootloader-0.810/src/Core/GRUB2EFI.pm new/perl-Bootloader-0.811/src/Core/GRUB2EFI.pm --- old/perl-Bootloader-0.810/src/Core/GRUB2EFI.pm 2014-04-03 14:16:53.000000000 +0200 +++ new/perl-Bootloader-0.811/src/Core/GRUB2EFI.pm 2014-04-10 11:12:33.000000000 +0200 @@ -882,14 +882,12 @@ if (defined $default and $default ne "") { $self->RunCommand ( - "/usr/sbin/grub2-set-default '$default'", - Bootloader::Path::BootCommandLogname() + "/usr/sbin/grub2-set-default '$default'" ); } return 0 == $self->RunCommand ( - "/usr/sbin/grub2-mkconfig -o /boot/grub2/grub.cfg", - Bootloader::Path::BootCommandLogname() + "/usr/sbin/grub2-mkconfig -o /boot/grub2/grub.cfg" ); } @@ -923,10 +921,7 @@ } } - $ret = $self->RunCommand ( - "$cmd $opt", - Bootloader::Path::BootCommandLogname() - ); + $ret = $self->RunCommand ("$cmd $opt"); return 0 if (0 != $ret); @@ -934,14 +929,12 @@ if (defined $default and $default ne "") { $self->RunCommand ( - "/usr/sbin/grub2-set-default '$default'", - Bootloader::Path::BootCommandLogname() + "/usr/sbin/grub2-set-default '$default'" ); } return 0 == $self->RunCommand ( - "/usr/sbin/grub2-mkconfig -o /boot/grub2/grub.cfg", - Bootloader::Path::BootCommandLogname() + "/usr/sbin/grub2-mkconfig -o /boot/grub2/grub.cfg" ); } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/perl-Bootloader-0.810/src/Core/LILO.pm new/perl-Bootloader-0.811/src/Core/LILO.pm --- old/perl-Bootloader-0.810/src/Core/LILO.pm 2014-04-03 14:16:53.000000000 +0200 +++ new/perl-Bootloader-0.811/src/Core/LILO.pm 2014-04-10 11:12:33.000000000 +0200 @@ -286,8 +286,7 @@ my $self = shift; return 0 == $self->RunCommand ( - Bootloader::Path::Lilo_lilo() . " -P ignore -v -v", - Bootloader::Path::BootCommandLogname() + Bootloader::Path::Lilo_lilo() . " -P ignore -v -v" ); } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/perl-Bootloader-0.810/src/Core/PowerLILO.pm new/perl-Bootloader-0.811/src/Core/PowerLILO.pm --- old/perl-Bootloader-0.810/src/Core/PowerLILO.pm 2014-04-03 14:16:53.000000000 +0200 +++ new/perl-Bootloader-0.811/src/Core/PowerLILO.pm 2014-04-10 11:12:33.000000000 +0200 @@ -678,8 +678,7 @@ my $self = shift; return 0 == $self->RunCommand ( - Bootloader::Path::Lilo_lilo(), - Bootloader::Path::BootCommandLogname() + Bootloader::Path::Lilo_lilo() ); } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/perl-Bootloader-0.810/src/Core/ZIPL.pm new/perl-Bootloader-0.811/src/Core/ZIPL.pm --- old/perl-Bootloader-0.810/src/Core/ZIPL.pm 2014-04-03 14:16:53.000000000 +0200 +++ new/perl-Bootloader-0.811/src/Core/ZIPL.pm 2014-04-10 11:12:33.000000000 +0200 @@ -381,8 +381,7 @@ my $self = shift; return 0 == $self->RunCommand ( - Bootloader::Path::Zipl_zipl(), - Bootloader::Path::BootCommandLogname() + Bootloader::Path::Zipl_zipl() ); } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/perl-Bootloader-0.810/src/Core.pm new/perl-Bootloader-0.811/src/Core.pm --- old/perl-Bootloader-0.810/src/Core.pm 2014-04-03 14:16:53.000000000 +0200 +++ new/perl-Bootloader-0.811/src/Core.pm 2014-04-10 11:12:33.000000000 +0200 @@ -80,7 +80,7 @@ C<< $status = Bootloader::Core->UpdateBootloader (); >> -C<< $status = Bootloader::Core->RunCommand ($command, $log_file); >> +C<< $status = Bootloader::Core->RunCommand ($command, $try); >> C<< $mapping_ref = Bootloader::Core->GetDeviceMapping (); >> @@ -1614,36 +1614,49 @@ } =item -C<< $status = Bootloader::Core->RunCommand ($command, $log_file); >> +C<< $status = Bootloader::Core->RunCommand ($command, $try); >> -Runs specified command. If log file is defined, its stdout and stderr -are appended to the log file. -As arguments, takes the command end the log file name. Returns -exit code of the command. +Runs specified command. +If $try is set, ignores command errors and returns 0. +Otherwise it returns the exit code of the command. +command, exit code, and output are stored internally in $self->{last_command}. =cut -# integer RunCommand (string command, string log_file) -sub RunCommand { - my $self = shift; - my $command = shift; - my $log = shift; +# integer RunCommand (string command, integer try) +sub RunCommand +{ + my $self = shift; + my $command = shift; + my $try = shift; - if (defined ($log)) - { - $command = "$command >$log 2>&1"; - } - else - { - $command = "$command >/dev/null 2>/dev/null"; - } - my $ret = system ($command); + my $ret; + my $output; - my $output = `cat $log`; - $self->milestone("run $command - ret $ret + output: $output"); - $self->error("Command '$command' failed with code $ret and output: $output") unless $ret == 0; + if(open my $f, "($command) 2>&1 |") { + local $/; + $output = <$f>; + close $f; + $ret = $? >> 8; + chomp $output; + $output .= "\n"; + } + else { + $ret = 127; + $output = "$command: " . ($! == 13 ? $! : "command not found") . " \n"; + } - return $ret; + $self->{last_command} = { cmd => $command, exit => $ret, out => $output}; + + if(!$ret || $try) { + $self->milestone("'$command' = $ret, output:", $output); + $ret = 0; + } + else { + $self->error("'$command' failed with exit code $ret, output:", $output); + } + + return $ret; } =item diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/perl-Bootloader-0.810/src/Library.pm new/perl-Bootloader-0.811/src/Library.pm --- old/perl-Bootloader-0.810/src/Library.pm 2014-04-03 14:16:53.000000000 +0200 +++ new/perl-Bootloader-0.811/src/Library.pm 2014-04-10 11:12:33.000000000 +0200 @@ -86,7 +86,7 @@ use base qw ( Bootloader::MBRTools Bootloader::FileIO Bootloader::Logger ); -our $VERSION = 0.000; +our $VERSION = "0.000"; my $instances = 0; my $global_id; @@ -517,15 +517,18 @@ my $loader = $self->{loader}; return undef unless defined $loader; - $self->milestone("menu_only = $menu_only"); + $self->milestone("creating config files"); $loader->{resolve_symlinks} = 1; my $new_lines_ref = $loader->CreateLines(); - if (!defined $new_lines_ref) { - $self->warning("no config - nothing written"); + + if(!defined $new_lines_ref) { + $self->warning("no config created - nothing written"); return undef; } + $self->milestone("writing config files (menu_only = $menu_only)"); + return $loader->WriteFiles($new_lines_ref, ".new", $menu_only); } @@ -794,16 +797,17 @@ =cut -sub GetSettings { - my $self = shift; +sub GetSettings +{ + my $self = shift; - my $loader = $self->{"loader"}; - return undef unless defined $loader; + my $loader = $self->{loader}; + return undef unless defined $loader; - $self->milestone( "TRACE"); - return $loader->GetSettings (); + return $loader->GetSettings(); } + =item C<< $status = Bootloader::Library->SetSettings (); >> @@ -816,16 +820,15 @@ =cut -sub SetSettings { - my $self = shift; - my $settings_ref = shift; - - my $loader = $self->{"loader"}; - return undef unless defined $loader; +sub SetSettings +{ + my $self = shift; + my $settings_ref = shift; - $self->milestone("TRACE"); + my $loader = $self->{loader}; + return undef unless defined $loader; - return $loader->SetSettings ($settings_ref); + return $loader->SetSettings($settings_ref); } # wrappers for easier use @@ -949,15 +952,14 @@ =cut -sub SetSections { - my $self = shift; - my $sections_ref = shift; +sub SetSections +{ + my $self = shift; + my $sections_ref = shift; - my %settings = ( - "sections" => $sections_ref - ); - return $self->SetSettings (\%settings) + $self->milestone("updating sections"); + return $self->SetSettings({sections => $sections_ref}); } =item @@ -982,14 +984,14 @@ } =cut -sub SetGlobalSettings { - my $self = shift; - my $global_ref = shift; +sub SetGlobalSettings +{ + my $self = shift; + my $global_ref = shift; + + $self->milestone("updating global settings"); - my %settings = ( - "global" => $global_ref - ); - return $self->SetSettings (\%settings) + return $self->SetSettings({global => $global_ref}); } =item diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/perl-Bootloader-0.810/src/Logger.pm new/perl-Bootloader-0.811/src/Logger.pm --- old/perl-Bootloader-0.810/src/Logger.pm 2014-04-03 14:16:53.000000000 +0200 +++ new/perl-Bootloader-0.811/src/Logger.pm 2014-04-10 11:12:33.000000000 +0200 @@ -58,7 +58,6 @@ my $self = shift; delete $self->{logger}{log_fh}; - delete $self->{logger}{log_fh_old}; delete $self->{logger}{log_fh_yast}; delete $self->{logger}{log_is_stderr}; @@ -76,14 +75,6 @@ $self->{logger}{log_fh} = $f; } - # old logfile for compatibility - if(!$ENV{PBL_DEBUG} && open my $f, ">>", Bootloader::Path::LognameOld()) { - my $tmp = select $f; - $| = 1; - select $tmp; - $self->{logger}{log_fh_old} = $f; - } - # also log to yast log if called from yast if($self->{session_id} =~ /^yast-/ && open my $f, ">>", Bootloader::Path::LognameYaST()) { my $tmp = select $f; @@ -140,6 +131,16 @@ } +# __log(level, message, var, depth) +# +# level: 0 .. 3 (debug, milestone, warning, error) +# message: log message (single line string) +# var (optional): either a SCALAR or a REF +# - SCALAR (may be multiline) will be logged in a block delimited +# by '<<<<<<<<<<<<<<<<' and '>>>>>>>>>>>>>>>>' +# - REF will be logged using Data::Dumper +# depth (optional): maximum depth when logging a REF +# sub __log { my $self = shift; @@ -166,8 +167,11 @@ if($_[0]) { my $x = $_[0]; + my $m = $_[1]; if(ref $x) { + $Data::Dumper::Maxdepth = $m if $m; chomp($x = Dumper $x); + $Data::Dumper::Maxdepth = 0 if $m; } else { chomp $x; @@ -181,10 +185,6 @@ print { $self->{logger}{log_fh} } "$prefix $message\n"; } - if($self->{logger}{log_fh_old}) { - print { $self->{logger}{log_fh_old} } "$prefix $message\n"; - } - if($self->{logger}{log_fh_yast}) { print { $self->{logger}{log_fh_yast} } "$prefix $self->{logger}{yast_prefix} $message\n"; } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/perl-Bootloader-0.810/src/Path.pm new/perl-Bootloader-0.811/src/Path.pm --- old/perl-Bootloader-0.810/src/Path.pm 2014-04-03 14:16:53.000000000 +0200 +++ new/perl-Bootloader-0.811/src/Path.pm 2014-04-10 11:12:33.000000000 +0200 @@ -90,18 +90,6 @@ } =item -C<< $path = Bootloader::Path::LognameOld(); >> - -our old logfile: /var/log/YaST2/perl-BL-standalone-log - -=cut - -sub LognameOld { - my $value = "/var/log/YaST2/perl-BL-standalone-log"; - return Prefix($value); -} - -=item C<< $path = Bootloader::Path::LognameYaST(); >> yast logfile: /var/log/YaST2/y2log @@ -113,18 +101,6 @@ return Prefix($value); } -=item -C<< $path = Bootloader::Path::BootCommandLogname(); >> - -Gets logname path. - -=cut - -sub BootCommandLogname { - my $value = "/var/log/YaST2/y2log_bootloader"; - return Prefix($value); -} - =item C<< $path = Bootloader::Path::Fstab(); >> diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/perl-Bootloader-0.810/src/Tools.pm new/perl-Bootloader-0.811/src/Tools.pm --- old/perl-Bootloader-0.810/src/Tools.pm 2014-04-03 14:16:53.000000000 +0200 +++ new/perl-Bootloader-0.811/src/Tools.pm 2014-04-10 11:12:33.000000000 +0200 @@ -967,31 +967,26 @@ # FIXME: Add documentation =cut -sub GetSectionList { - my %option = @_; - my $loader = GetBootloader (); - - normalize_options(\%option); - my @sections = @{$lib_ref->GetSections ()}; - - # Print sections from file to logfile - $lib_ref->milestone("sections from file:\n' " . - join("'\n' ", - map { - $_->{"name"}; - } @sections) . "'\n" - ); - - my @section_names = map { - match_section($_, \%option) ? $_->{"name"} : (); - } @sections; - - # Print found sections to logfile - $lib_ref->milestone("Found sections:\n' " . - join("'\n' ", @section_names) . "'\n" - ); +sub GetSectionList +{ + my $self = $lib_ref; - return @section_names; + my %option = @_; + my $loader = GetBootloader(); + + $self->milestone("search options:", \%option); + + normalize_options(\%option); + + my @sections = @{$self->GetSections()}; + + my @section_names = map { + match_section($_, \%option) ? $_->{name} : (); + } @sections; + + $self->milestone("sections matched:", \@section_names); + + return @section_names; } @@ -1001,13 +996,17 @@ # FIXME: Add documentation =cut -sub GetSection { - my $name = shift or return undef; +sub GetSection +{ + my $self = $lib_ref; + + my $name = shift or return undef; + + for (@{$self->GetSections()}) { + return $_ if $_->{name} eq $name; + } - foreach (@{$lib_ref->GetSections ()}) { - return $_ if $_->{"name"} eq $name; - } - return undef; + return undef; } =item diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/perl-Bootloader-0.810/version new/perl-Bootloader-0.811/version --- old/perl-Bootloader-0.810/version 2014-04-03 14:16:53.000000000 +0200 +++ new/perl-Bootloader-0.811/version 2014-04-10 11:12:33.000000000 +0200 @@ -1 +1 @@ -0.810 +0.811 -- To unsubscribe, e-mail: opensuse-commit+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-commit+help@opensuse.org